agent-core-review

Reviews code and tests in packages/agent-core-v2 using abstraction-level and contract-testing lenses.

18|8|Updated Jun 17, 2026
One-click install
npx skills add https://github.com/PyModel/pythinker-code --skill agent-core-review-pymodel
Or copy as Structured Prompt for Agent
Please help me install this Agent Skill.
Skill: agent-core-review
Source: https://github.com/PyModel/pythinker-code/tree/main/.agents/skills/agent-core-review
Command: npx skills add https://github.com/PyModel/pythinker-code --skill agent-core-review-pymodel

SYSTEM DOCUMENTATION & REQUIREMENTS

What problem does it solve? Code reviews and test reviews in the agent-core-v2 engine often lack consistent criteria, producing subjective severity labels and uneven feedback. This Skill supplies calibrated review lenses — single-level-of-abstraction analysis and contract-driven test rules — so findings are reported as factual evidence with file:line references instead of opinionated verdicts. ## Core Features & Use Cases - Abstraction-Level Review (slop lens): Detects functions that mix levels of abstraction or handle errors inline, reporting raw counts, evidence locations, and proposed moves (push down into helpers or up into edge handlers). Invoked only on explicit request. - Test Writing & Review (test lens): Applies contract-driven rules — one behavior per test, drive through the public surface, stub only true external boundaries — for both authoring new tests and auditing existing ones. - Use Case: When reviewing a pull request in packages/agent-core-v2, ask for the abstraction lens on a complex function and receive per-check detections, control-flow counts, exemption flags, and concrete refactoring directions without subjective severity grades. ## Quick Start Review this function in packages/agent-core-v2 using the single level of abstraction lens and report where each foreign concern should move.

Frequently Asked Questions about agent-core-review

High-intent search queries and answers about installing and using this skill.

FAQPage Schema
How do I review a function for single level of abstraction violations?

Explicitly request the slop lens on the target function. The review classifies each statement as core, down, up, or cross-cutting, reports detections with file:line evidence and raw counts, then proposes moving foreign concerns down into helpers or up into edge handlers.

How do I write tests that test the contract instead of the implementation?

Use the test lens in write mode: one behavior per it block, drive through the public surface, stub only the true external boundary, and control time or config through documented knobs. This keeps tests clear, isolated, and refactor-resilient.

Does this review skill apply to packages other than agent-core-v2?

No. The lenses are calibrated specifically for the v2 engine built on DI and Scope. They must not be applied to the legacy packages/agent-core or any other package in the repository.

Why does the review report facts instead of severity grades?

Severity labels compress continuous measurements into an uncalibrated three-point scale, causing inconsistent verdicts across reviewers. The skill reports detections, raw counts, directions, and exemptions, leaving grading to a downstream rubric, anchored examples, or a human.

When should the slop abstraction lens not be used?

Do not apply it unprompted to general reviews or refactors; it activates only on explicit request. Exemptions also exist for tiny functions, dedicated validators or mappers, atomicity requirements, and edge-translator functions.