architecture-quality-review

Load the invariant checklist, run git diff --stat to scope changed files, then verify layering, DI composition, static-class purity, and retry bounds. Emit graded MUST-FIX, SHOULD-FIX, and NIT findings with file:line evidence and a final verdict.

Search for GetAwaiter().GetResult() or .Result in Infrastructure code bridging sync interfaces to async libraries. Fix by adding an async method like RenderAsync, or use ConfigureAwait(false) with a context-free caller to avoid deadlocks.

Enforce screaming architecture with domain-named folders, clean layering via a DomainPurityTests allowlist, DI composition through AddInfrastructure and AddApiServices, pure-only static classes, guard clauses, LoggerMessage patterns, and bounded retry with MaxAttempts.

Static classes performing I/O, such as GetManifestResourceStream calls, violate the pure-only rule and hide testable seams. Extract the behavior into an injectable interface like ICvHtmlBuilder registered as a singleton so it can be mocked in tests.

Replace computed properties that call ToList, ToArray, or ToHashSet on every access with explicit constructors or init blocks that compute the collection once. Store the result in a backing field or expose a pre-computed FrozenSet.

Use it for multi-layer .NET waves touching Domain, Infrastructure, and Api projects, especially with Cosmos or Durable components, when a pre-merge invariant verdict is needed. General reviews suit style and logic concerns outside these invariants.