async-signal-safety-review

Review KSCrash signal-handling code for async-signal-safety issues against Apple OSS implementations.

4.5k|739|Updated Jun 17, 2012

Search Tags:#code-review #async-signal-safety #kscrash #apple-oss-distributions #signal-handlers #crash-handling

Ready to run

npx skills add https://github.com/kstenerud/KSCrash --skill async-signal-safety-review

💬 Prompt for ChatGPT / Claude Chat▼

Please help me install this Agent Skill.
Skill: async-signal-safety-review
Source: https://github.com/kstenerud/KSCrash/tree/main/.claude/skills/async-signal-safety-review
Command: npx skills add https://github.com/kstenerud/KSCrash --skill async-signal-safety-review

SYSTEM DOCUMENTATION & REQUIREMENTS

What problem does it solve?

Review code changes for async-signal-safety violations in KSCrash crash handlers, signal handlers, and monitor code, and verify suspect system calls against Apple OSS ground-truth rather than guessing.

Core Features & Use Cases

Ground-truth verification of asynchronous-signal-safety for changes touching signal handlers, Mach exception handlers, or any code reachable from KSCrash sources.
Review scope includes PR diffs, branches, and individual files; ensures safety before landing risky changes.
Uses Apple's open-source distributions as the reference to confirm safety.

Quick Start

Provide the PR number, branch, or file path to begin the async-signal-safety review.

Frequently Asked Questions about async-signal-safety-review

High-intent search queries and answers about installing and using this skill.

FAQPage Schema

How do I verify async-signal-safety in KSCrash signal handlers?▼

Verify async-signal-safety in KSCrash by reviewing diffs, branches, and files touching signal-handling paths, then cross-checking suspect system calls against Apple OSS distributions to confirm safety and gather concrete evidence.

What is async-signal-safety and why does it matter for crash handlers?▼

Async-signal-safety ensures functions can execute safely within signal handlers without causing deadlocks or undefined behavior, which is critical for crash handlers and Mach exception handlers to capture crash-time data reliably.

Can I use Apple OSS distributions to check if system calls are async-signal-safe?▼

Yes, you can use Apple's open-source distributions as ground-truth reference to verify whether suspect system calls in KSCrash code paths are async-signal-safe rather than guessing, producing evidence-backed safety reports.

What are the limitations of reviewing async-signal-safety in crash-time paths?▼

The review focuses specifically on KSCrash signal handlers, Mach exception handlers, and monitor code reachable from KSCrash sources, ensuring safety before landing risky changes but scoped to the provided diffs, branches, or files.

Why does my KSCrash signal handler deadlock during crash reporting?▼

Signal handler deadlocks during crash reporting often stem from calling non-async-signal-safe functions; reviewing the code paths against Apple OSS implementations identifies unsafe call sites causing the deadlock.