bdd-test-review

Reviews pytest-bdd Gherkin scenarios and test data in pull requests for completeness and validity.

8|15|Updated Jan 17, 2025
One-click install
npx skills add https://github.com/Netcracker/qubership-envgene --skill bdd-test-review-netcracker
Or copy as Structured Prompt for Agent
Please help me install this Agent Skill.
Skill: bdd-test-review
Source: https://github.com/Netcracker/qubership-envgene/tree/main/.claude/skills/bdd-test-review
Command: npx skills add https://github.com/Netcracker/qubership-envgene --skill bdd-test-review-netcracker

SYSTEM DOCUMENTATION & REQUIREMENTS

💡 This Skill includes references (resource) components.

What problem does it solve? AI-generated or human-written BDD tests can be green while verifying nothing: empty oracles, self-blessing goldens, and non-discriminating test data slip into suites and erode trust. This Skill performs a structured expert review of pytest-bdd/Gherkin PRs in the qubership-envgene repository to catch those defects before the suite is trusted. ## Core Features & Use Cases - Four-axis validation: Checks scenario completeness against docs and code, scenario validity (doc conformance, oracle strength, oracle independence, determinism), test-data completeness, and test-data validity. - Doc-vs-code divergence resolution: Builds a numbered divergence list, determines which side violates the authoritative contract, and drives resolution with the user via issues, docs PRs, or @xfail(strict) markers. - Canonical verdict report: Produces a per-scenario verdict table (valid, weak, invalid, missing, not needed), proposed Gherkin drafts, a test-data matrix, and notes, published as a PR comment only on explicit approval. - Use Case: A PR adds Gherkin scenarios for the effective-set generator. Invoke /bdd-test-review to verify each scenario exercises the real CLI, that payloads fail at the claimed point, and that goldens are independently derivable from the documented contract. ## Quick Start Ask the assistant to run /bdd-test-review on a specific pull request number that adds or changes BDD scenarios in the qubership-envgene repository.

Frequently Asked Questions about bdd-test-review

High-intent search queries and answers about installing and using this skill.

FAQPage Schema
How do I review BDD test scenarios in a pull request?

Invoke /bdd-test-review explicitly with the PR number. The skill fetches the PR head into a worktree, reads the feature files, step definitions, test data, docs, and schemas, then produces a per-scenario verdict report published as a PR comment after your approval.

What does the bdd-test-review skill check in Gherkin scenarios?

It validates four axes: scenario completeness against docs and code, scenario validity (doc conformance, oracle strength, oracle independence, determinism), test-data completeness, and test-data validity including schema conformance and discriminating power.

Does bdd-test-review trigger automatically on any PR review request?

No. It is invoked only via the explicit /bdd-test-review command and does not auto-trigger on loosely matching requests such as a general PR review. This scoping is stated in the skill's own description.

What is a self-blessing test and how is it detected?

A self-blessing test is confirmed by product code changed in the same PR, so it cannot catch regressions. The skill diffs the PR against its own base branch, flags scenarios verifying PR-introduced behavior, and checks that mocks do not replace the real component under test.

When is a scenario marked invalid instead of weak?

A scenario is invalid when it passes even while the behavior is broken, for example existence-only assertions on pre-existing files or assertions encoding a current bug. Weak means the checks exist but cannot distinguish some wrong outcomes from the right one.

Can the review publish or file issues without confirmation?

No. All issues, docs PRs, and the final report are drafted and proposed as one batch, but nothing is filed, committed, pushed, or posted as a PR comment without the user's explicit go-ahead.