skills.rest
portalshq
portalshqOFFICIAL
Explore all skills by this author →
GitHub

code-review-excellence

Reviews pull requests with structured feedback, checklists, and severity-labeled comments.

5|Updated Dec 8, 2025
Search Tags:#code quality#code review#feedback#pull request#mentoring#review process#security checklist
One-click install
npx skills add https://github.com/portalshq/portals-studio --skill code-review-excellence-portalshq
Or copy as Structured Prompt for Agent▼
Please help me install this Agent Skill.
Skill: code-review-excellence
Source: https://github.com/portalshq/portals-studio/tree/main/.cursor/skills/code-review-excellence
Command: npx skills add https://github.com/portalshq/portals-studio --skill code-review-excellence-portalshq

SYSTEM DOCUMENTATION & REQUIREMENTS

What problem does it solve? Code reviews often become inconsistent, slow, or demoralizing when reviewers lack a systematic approach, leading to missed bugs, nitpicky feedback, and stalled pull requests. ## Core Features & Use Cases - Structured Four-Phase Review Process: Guides reviewers through context gathering, high-level design review, line-by-line analysis, and a clear approve/comment/request-changes decision. - Severity-Labeled Feedback System: Uses labels like blocking, important, nit, suggestion, and praise to differentiate critical issues from optional improvements. - Language-Specific Checklists: Provides Python and TypeScript/JavaScript anti-patterns plus security, performance, and testing checklists. - Use Case: A senior engineer reviewing a 350-line pull request uses the phased process and security checklist to catch an SQL injection vulnerability, label it as blocking, and suggest a parameterized query fix with example code. ## Quick Start Review the attached pull request diff using the code review checklist and provide severity-labeled feedback with a final verdict.

Frequently Asked Questions about code-review-excellence

High-intent search queries and answers about installing and using this skill.

FAQPage Schema
What should I look for when reviewing a pull request?▼

Review logic correctness, edge cases, security vulnerabilities, performance issues, test coverage, and architectural fit. Skip formatting and linting issues since automated tools like Prettier and linters handle those.

How long should a code review take?▼

A typical review takes 20-35 minutes across four phases: context gathering, high-level review, line-by-line analysis, and summary. Limit sessions to 60 minutes and keep pull requests under 400 lines for effective review.

What are common Python code review issues to check?▼

Check for mutable default arguments, overly broad exception handling, and mutable class attributes shared across instances. These are frequent Python bugs that cause unexpected behavior across function calls and object instances.

How do I handle disagreements during code review?▼

Seek to understand the author's reasoning first, acknowledge valid points, and provide data such as benchmarks to support concerns. Escalate to an architect if unresolved, and approve non-critical working code rather than blocking on preferences.

When should I request changes versus approve a pull request?▼

Request changes only for blocking issues like security vulnerabilities, correctness bugs, or missing critical tests. Approve with comments for minor suggestions, and avoid blocking on style preferences or personal taste.

Related Skills

Explore More Software Engineering Skills→
otomattyotomatty
3

create-pull-request

Create and update GitHub pull requests with automated checks and template descriptions.

Community
Advanced
AnveioAnveio
1

kpi-pr-throughput

Measure PR merge throughput metrics across agent sessions with quality gates.

Community
Advanced
ArdurAIArdurAI
1

god-dev-codebase

Automate codebase review, security audits, and performance analysis.

Official
Advanced
moduloMomentsmoduloMoments
7

pair

Facilitate pair programming sessions for code review and collaborative file changes.

Official
Intermediate