Code Review

Review Meshtastic-Android code for Kotlin Multiplatform architecture and testing standards.

1.8k|498|Updated Jan 20, 2020
One-click install
npx skills add https://github.com/meshtastic/Meshtastic-Android --skill code-review-meshtastic
Or copy as Structured Prompt for Agent
Please help me install this Agent Skill.
Skill: Code Review
Source: https://github.com/meshtastic/Meshtastic-Android/tree/main/.skills/code-review
Command: npx skills add https://github.com/meshtastic/Meshtastic-Android --skill code-review-meshtastic

SYSTEM DOCUMENTATION & REQUIREMENTS

💡 This Skill includes references (resource) components.

What problem does it solve?

This Skill streamlines the process of performing thorough code reviews for Meshtastic-Android, ensuring adherence to architecture, coroutine safety, dependency management, and best practices.

Core Features & Use Cases

  • Architecture Verification: Checks for proper KMP source set boundaries, clean separation of platform-specific code, and correct use of interfaces over expect/actual.
  • UI & Compose Standards: Ensures string resources are used correctly, dialogs are centralized, placeholders are implemented, and adaptive layouts follow best practices.
  • Navigation & State Checks: Validates that navigation graphs are shared, ViewModels are scoped properly, and navigation host modules are correctly used.
  • Dependency & Networking Standards: Enforces the use of Ktor over OkHttp, correct dependency aliases, and network configuration practices.
  • Testing & Build Integrity: Confirms tests are placed properly, testing libraries are used, and ProGuard rules are maintained.

Quick Start

Review the code in the repository to verify compliance with architecture guidelines, especially in the commonMain, androidMain, and UI modules, focusing on source set boundaries and resource usage.

Frequently Asked Questions about Code Review

High-intent search queries and answers about installing and using this skill.

FAQPage Schema
How do I verify Kotlin Multiplatform source set boundaries in a code review?

To verify Kotlin Multiplatform source set boundaries during code review, check that commonMain and androidMain maintain clean separation, use interfaces over expect/actual declarations, and enforce proper architecture limits for high-quality maintainable code.

What's the best way to structure navigation and ViewModels in a KMP Android project?

Structuring navigation and ViewModels in KMP Android requires validating that navigation graphs are shared, ViewModels are scoped properly, and navigation host modules are correctly used to ensure standardized architecture boundaries.

Does this code review process enforce Ktor over OkHttp for networking?

Yes, the code review process enforces Ktor over OkHttp for networking. It validates correct dependency aliases, network configuration practices, and safe dependency configurations to maintain high-quality Kotlin Multiplatform standards.

How do I check Compose UI standards like string resources and placeholders?

Checking Compose UI standards involves verifying that string resources are used correctly, dialogs are centralized, placeholders are implemented, and adaptive layouts follow best practices for standardized Kotlin Multiplatform code.

What testing and build integrity checks are needed for Kotlin Multiplatform code?

Testing and build integrity checks for Kotlin Multiplatform code confirm that tests are placed properly, testing libraries are used, and ProGuard rules are maintained to ensure high-quality and safe dependency configurations.

Can I automate coroutine safety checks for my Android codebase?

Yes, you can automate coroutine safety checks for your Android codebase by applying code review standards that verify architecture boundaries, coroutine safety, and dependency management to ensure maintainable Kotlin Multiplatform code.