skills.rest
austintheriot
austintheriotCOMMUNITY
Explore all skills by this author →
GitHub

data-flow-review

Review code diffs for data-flow, state-ownership, and boundary mismatches.

1|Updated Jul 31, 2023
Search Tags:#architecture#code review#state management#data flow#ownership#lifetime#boundary topology
One-click install
npx skills add https://github.com/austintheriot/dotfiles --skill data-flow-review
Or copy as Structured Prompt for Agent▼
Please help me install this Agent Skill.
Skill: data-flow-review
Source: https://github.com/austintheriot/dotfiles/tree/main/.claude/skills/data-flow-review
Command: npx skills add https://github.com/austintheriot/dotfiles --skill data-flow-review

SYSTEM DOCUMENTATION & REQUIREMENTS

💡 This Skill includes references (resource) components.

What problem does it solve?

It helps prevent design and implementation mismatches where data ownership, lifetime, and boundary placement become unclear, leading to hard-to-debug correctness issues like stale state, hidden shared mutable state, wrong direction of data flow, and missing teardown.

Core Features & Use Cases

  • Boundary and ownership diagnostics: Reviews who creates, owns, consumes, and decides about each non-trivial entity, flagging conceptual scope vs instantiation scope mismatches.
  • Topology-first findings: Prioritizes a “draw the data-flow diagram before reading the body” discipline and proposes fixes as reassignment or concrete text-shaped diagrams.
  • Diff-aware review workflows: By default reviews against main, or targets a specific file/path, PR number, or git range; can auto-delegate deeper topology questions to a data-flow subagent.
  • Severity-labeled, read-only output: Produces structured findings (with file:line references and diagrams for major/insight) without posting comments.

Quick Start

Ask for a review by saying: run data-flow-review for the current branch against main.

Frequently Asked Questions about data-flow-review

High-intent search queries and answers about installing and using this skill.

FAQPage Schema
How do I review data flow and state ownership issues in a pull request?▼

Reviewing data flow and state ownership involves analyzing branch diffs against main to identify mismatches between conceptual responsibility and implementation scope. The process produces severity-labeled findings with file:line references and concrete data-flow diagrams.

What is boundary topology analysis in software architecture?▼

Boundary topology analysis examines who creates, owns, consumes, and decides about non-trivial entities within a system. It flags mismatches between conceptual scope and instantiation scope to catch hidden shared mutable state and wrong data flow direction early.

How do I check for stale state and lifetime bugs before merging code?▼

Checking for stale state and lifetime bugs requires a topology-first review that draws data-flow diagrams before reading code bodies. This discipline identifies missing teardowns and ownership mismatches, proposing fixes as concrete text-shaped diagrams.

Can I run a data flow review on a specific git range or file path?▼

Yes, data flow review supports targeted file and path inspections, specified git ranges, and PR-based checks. By default it reviews the current branch against main, with optional deep delegation to a data-flow subagent for complex topology questions.

What is the best way to visualize state ownership and data flow mismatches?▼

The best way to visualize state ownership mismatches is generating severity-labeled findings with concrete text-shaped data-flow diagrams. This approach maps instantiation scope against conceptual responsibility without posting comments, keeping the review output strictly read-only.

Related Skills

Explore More Software Engineering Skills→
austintheriotaustintheriot
1

distsys-review

Review distributed-systems code diffs for correctness and operability hazards.

Community
Advanced
cecon123cecon123

rust-ownership

Diagnose and remediate Rust ownership, borrowing, and lifetime errors.

Community
Advanced
wonderslifewonderslife
13

expert-arch-enforcer

Enforce architecture constraints across codebases with a six-layer dependency model.

Community
Advanced
jeffss00jeffss00

code-review-linus

Review code architecture and quality using Linus Torvalds' engineering principles.

Community
Advanced