definition-of-done-validator

Validates acceptance criteria in spec files have automated test coverage before PR approval.

6|1|Updated May 13, 2026
One-click install
npx skills add https://github.com/Xipher-Labs/walter-os --skill definition-of-done-validator
Or copy as Structured Prompt for Agent
Please help me install this Agent Skill.
Skill: definition-of-done-validator
Source: https://github.com/Xipher-Labs/walter-os/tree/main/skills/definition-of-done-validator
Command: npx skills add https://github.com/Xipher-Labs/walter-os --skill definition-of-done-validator

SYSTEM DOCUMENTATION & REQUIREMENTS

What problem does it solve?

It prevents the “tests pass but the feature is wrong” failure mode by ensuring the written acceptance criteria in a spec are actually verified by tests.

Core Features & Use Cases

  • Acceptance-criteria coverage validation: Verifies that every - [AC-N] criterion under ## Acceptance Criteria in docs/specs/<slug>.md has at least one corresponding test reference.
  • Business-workflow test enforcement for personal projects: For regulated personal projects, requires the presence of tests/business/<project>/ and ensures business workflow tests exist.
  • Final PR/branch gate: Designed to run as a blocking gate before PR approval/creation and during branch-flow validation, refusing approval when criteria are uncovered or only “implicit”/weak coverage is detected.

Quick Start

Run the definition-of-done-validator before opening a PR or promoting a branch to catch any uncovered acceptance criteria and block approval until tests are added.

Frequently Asked Questions about definition-of-done-validator

High-intent search queries and answers about installing and using this skill.

FAQPage Schema
How do I block PRs when acceptance criteria lack test coverage?

To block PRs when acceptance criteria lack test coverage, use a quality gate that parses spec files, extracts acceptance criteria, maps them to test markers, and refuses PR approval when criteria are uncovered or only implicitly tested.

What is spec validation for automated tests in feature development?

Spec validation for automated tests is the process of verifying that every acceptance criterion written in a feature specification has at least one corresponding automated test reference, preventing the failure mode where tests pass but the feature is wrong.

How do I enforce business-workflow tests for regulated personal projects?

You can enforce business-workflow tests for regulated personal projects by applying a validation gate that requires the presence of tests/business/project/ directories and ensures the corresponding business workflow tests exist before branch promotion.

How do I validate branch flow and ensure work is sufficiently tested before promotion?

To validate branch flow and ensure work is sufficiently tested before promotion, run a spec validation gate during branch-flow validation that detects uncovered or weak coverage of acceptance criteria and blocks approval until tests are added.

What's the best way to detect weak or implicit test coverage for acceptance criteria?

The best way to detect weak or implicit test coverage for acceptance criteria is to parse the spec file, extract each criterion, map test markers to criteria, and automatically flag any criterion that lacks direct or explicit automated test references.

Do I need markdown spec files to validate acceptance criteria test coverage?

Yes, you need markdown spec files located at docs/specs/slug.md containing a dedicated Acceptance Criteria section, as the validator parses these files to extract criteria and map them to corresponding automated tests.