driver-review

Review embedded driver changes for DMA, interrupt, and peripheral access safety.

7.5k|1.8k|Updated Nov 10, 2013
One-click install
npx skills add https://github.com/FastLED/FastLED --skill driver-review
Or copy as Structured Prompt for Agent
Please help me install this Agent Skill.
Skill: driver-review
Source: https://github.com/FastLED/FastLED/tree/main/.claude/skills/driver-review
Command: npx skills add https://github.com/FastLED/FastLED --skill driver-review

SYSTEM DOCUMENTATION & REQUIREMENTS

What problem does it solve?

Hardware driver changes can introduce subtle DMA and interrupt issues that are hard to detect in review. This skill provides a structured, safety-focused framework for examining driver changes and ensuring hardware safety and correctness.

Core Features & Use Cases

  • Structured checks for DMA safety, interrupt safety, and peripheral register access
  • Review all driver code changes (src/platforms/**, /drivers/, DMA buffers, GPIO configuration, and timing/interrupt handling)
  • Produce remediation suggestions and a summary report to improve code quality before merges

Quick Start

Run git diff --cached and git diff to see all changes, then review driver code for DMA safety and interrupt correctness.

Frequently Asked Questions about driver-review

High-intent search queries and answers about installing and using this skill.

FAQPage Schema
How do I review embedded driver code for DMA and interrupt safety issues?

Review embedded driver code for DMA and interrupt safety by checking DMA buffer alignment, verifying ISR safety, ensuring volatile register access, and validating proper initialization and teardown to produce a structured remediation summary.

What is DMA safety in embedded driver development and why does it matter?

DMA safety in embedded drivers ensures direct memory access operations do not corrupt data or cause race conditions. It requires proper buffer alignment and volatile register access to prevent subtle hardware issues that are difficult to detect during standard code reviews.

How do I check ESP32 peripheral driver changes for ISR safety before merging?

Check ESP32 peripheral driver changes for ISR safety by reviewing timer and interrupt handling code, verifying GPIO configuration, and ensuring all DMA buffers are safely accessed. Apply structured checks to produce a remediation summary before merging.

Does this driver code review framework work for any embedded platform or only specific ones?

This driver code review framework applies to embedded driver changes across all platforms. It focuses on examining DMA buffers, GPIO configuration, and timer/interrupt handling universally, ensuring hardware safety and correctness regardless of the specific embedded platform.

What should I look for when auditing volatile register access in embedded drivers?

When auditing volatile register access in embedded drivers, look for proper use of volatile keywords to prevent compiler optimizations from breaking hardware interactions. Check peripheral access patterns, DMA alignment, and interrupt handling to ensure safe register reads and writes.

What are the limitations of automated hardware driver code reviews for DMA safety?

Automated hardware driver code reviews for DMA safety provide structured static analysis of code changes but cannot fully validate runtime hardware behavior. They identify potential interrupt safety, peripheral access, and alignment issues to guide remediation but require physical testing for final verification.