effect-anti-pattern-review

Identify and remediate React useEffect anti-patterns in PR changes.

Updated Aug 23, 2026
One-click install
npx skills add https://github.com/MajorLift/metamask-extension-skills --skill effect-anti-pattern-review
Or copy as Structured Prompt for Agent
Please help me install this Agent Skill.
Skill: effect-anti-pattern-review
Source: https://github.com/MajorLift/metamask-extension-skills/tree/main/domains/ui-performance/skills/effect-anti-pattern-review
Command: npx skills add https://github.com/MajorLift/metamask-extension-skills --skill effect-anti-pattern-review

SYSTEM DOCUMENTATION & REQUIREMENTS

What problem does it solve?

Helps code reviewers quickly identify and fix common React useEffect anti-patterns in PR diffs before merging.

Core Features & Use Cases

  • Grep and map PR changes to known useEffect anti-patterns.
  • Enforce best practices such as proper dependencies and cleanup across both metamask-extension and metamask-mobile.
  • Provide actionable guidance and suggested fixes during review.

Quick Start

Review a PR branch to surface useEffect anti-pattern findings and suggested fixes.

Frequently Asked Questions about effect-anti-pattern-review

High-intent search queries and answers about installing and using this skill.

FAQPage Schema
How do I identify React useEffect anti-patterns in a PR diff?

Identify React useEffect anti-patterns in a PR diff by applying a grep-driven checklist that maps modified useEffect, setInterval, setTimeout, or fetch calls to known anti-patterns and ties each hit to a concrete fix.

What are common React useEffect anti-patterns to check during code review?

Common React useEffect anti-patterns include missing or incorrect dependency arrays, absent cleanup functions for intervals and timeouts, and improperly handled fetch calls, all enforced through a deterministic grep checklist.

Does this useEffect review work for both metamask-extension and metamask-mobile?

Yes, this useEffect review works for both metamask-extension and metamask-mobile, enforcing proper dependencies and cleanup best practices across both React codebases during PR changes.

How do I enforce proper useEffect cleanup and dependencies before merging?

Enforce proper useEffect cleanup and dependencies before merging by running a grep-driven audit on PR changes that detects anti-patterns and provides actionable guidance with suggested fixes.

What is the best way to automate React useEffect code review for anti-patterns?

The best way to automate React useEffect code review is using a grep-driven checklist that scans PR diffs for anti-patterns in effects, intervals, and fetch calls, then ties hits to documented deterministic fixes.