skills.rest
dotnet
dotnetOFFICIAL
Explore all skills by this author →
Website𝕏@dotnetfdnGitHub

expert-reviewing

Route vstest pull request changes to targeted review dimensions based on affected folders.

1.2k|337|Updated Oct 13, 2022
Search Tags:#Routing#test platform#Code review#Pull request#DotNet#VSTest#review dimensions
One-click install
npx skills add https://github.com/dotnet/dotnet --skill expert-reviewing
Or copy as Structured Prompt for Agent▼
Please help me install this Agent Skill.
Skill: expert-reviewing
Source: https://github.com/dotnet/dotnet/tree/main/src/vstest/.github/skills/expert-review
Command: npx skills add https://github.com/dotnet/dotnet --skill expert-reviewing

SYSTEM DOCUMENTATION & REQUIREMENTS

What problem does it solve?

Reviewing large vstest pull requests without focus leads to shallow, generic feedback. This Skill maps changed files and folders to specific review dimensions so reviewers concentrate only on the concerns relevant to the modified subsystems.

Core Features & Use Cases

  • Folder-to-Dimension Routing: Maps vstest source folders (e.g., CrossPlatEngine, ObjectModel, CommunicationUtilities) to applicable review dimensions like IPC Transport Stability or Public API Surface Protection.
  • Dimension Summaries: Provides quick-reference definitions for 16 review dimensions covering parallelism, crash dumps, backward compatibility, and more.
  • Scenario Playbooks: Pre-built activation guidance for common PR types such as dependency bumps, RunSettings changes, or testhost modifications.
  • Use Case: When a PR modifies src/Microsoft.TestPlatform.ObjectModel/, the Skill directs the reviewer to check Public API Surface Protection, Backward Compatibility, and Cross-TFM Framework Resolution rather than reviewing everything.

Quick Start

Ask the expert-reviewer agent to review a vstest pull request and it will use this routing table to activate only the relevant review dimensions.

Frequently Asked Questions about expert-reviewing

High-intent search queries and answers about installing and using this skill.

FAQPage Schema
How do I review a vstest pull request by subsystem?▼

Identify which folders the PR changes, then consult the routing table to find the applicable review dimensions. Each folder maps to two or three dimensions such as Parallel Execution Safety or Error Reporting Clarity that define what to check.

What review dimensions apply to vstest ObjectModel changes?▼

Changes to src/Microsoft.TestPlatform.ObjectModel activate Public API Surface Protection, Backward Compatibility and Rollback Safety, and Cross-TFM and Framework Resolution. These cover unintentional API exposure, PublicAPI.txt management, and multi-targeting behavior.

Does this skill perform the code review itself?▼

No, it only provides the routing configuration mapping folders to review dimensions. The expert-reviewer agent owns the full CHECK methodology, severity classification, and review decisions; this skill tells it which dimensions to activate.

How does the folder routing work with the expert-reviewer agent?▼

The agent identifies changed files in the PR, looks up the routing table to map folders to dimensions, activates only those dimensions, and produces findings limited to them. Invoke it by referencing @expert-reviewer in a PR comment.

When should I not use this routing skill?▼

Do not use it for build or test command execution, which belongs to the vstest-build-test skill, or for parsing TRX test result files, which belongs to the trx-analysis skill. It is strictly for review dimension routing.

Related Skills

Explore More Software Engineering Skills→
commercetoolscommercetools
154

pr-review-navigator

Generate dependency-aware review paths for GitHub pull requests with mermaid flowcharts and tables.

Official
Intermediate
cloudflarecloudflare
5.2k

reconcile-code-review

Classifies code review findings as active, ignored, or resolved against PR history.

Official
Intermediate
logic-mathlogic-math
22

verify-go-changes

Validate Go code modifications by running compile and test commands.

Community
Intermediate
e-t-y-be-t-y-b
9

code-reviewer

Identify code-quality issues in PRs with severity-labeled findings and fixes.

Official
Advanced