fp-review

Analyzes code diffs and reports severity-labeled FP improvement opportunities with file:line references.

1|Updated Jul 31, 2023
One-click install
npx skills add https://github.com/austintheriot/dotfiles --skill fp-review-austintheriot
Or copy as Structured Prompt for Agent
Please help me install this Agent Skill.
Skill: fp-review
Source: https://github.com/austintheriot/dotfiles/tree/main/.claude/skills/fp-review
Command: npx skills add https://github.com/austintheriot/dotfiles --skill fp-review-austintheriot

SYSTEM DOCUMENTATION & REQUIREMENTS

What problem does it solve?

This Skill helps you spot high-leverage functional-programming opportunities in the code you’re actively changing, so your reviews catch design, exhaustiveness, and effect-management issues early.

Core Features & Use Cases

  • Functional-programming review of diffs: Reviews changes against main (default), producing severity-labeled findings with file:line references.
  • Targeted review modes: Supports reviewing a specific file/path, a PR number, or a git range, with language-specific FP moves for Rust, TypeScript, Python, Swift, and others.
  • Specialist routing for depth: Automatically delegates deep questions to type, effects, or verification subagents (fp-types, fp-effects, fp-verification) and includes tradeoffs and when FP would be a regression.

Quick Start

Run fp-review on your changed code by asking the agent: Review the current branch diff for functional-programming opportunities and report severity-labeled findings with file:line references.

Frequently Asked Questions about fp-review

High-intent search queries and answers about installing and using this skill.

FAQPage Schema
How do I review a code diff for functional programming improvements?

Code diff review for functional programming improvements analyzes changes against main, specific paths, PR numbers, or git ranges to produce severity-labeled findings with file:line references. It identifies ADT design, exhaustiveness, and effect tracking opportunities.

What functional programming patterns can I check for during a code review?

Functional programming code review checks for ADT design, exhaustiveness, effect tracking, pure-core/imperative-shell separation, and safer error handling. It applies language-specific moves to raise code quality without requiring wholesale rewrites.

Can I review TypeScript or Python code for functional programming issues?

Yes, functional programming review supports multi-language codebases including Rust, TypeScript, Python, and Swift. It applies language-specific FP moves tailored to each language's unique type system and effect tracking capabilities.

Does functional programming review exclude generated files and build artifacts?

Yes, functional programming review applies default exclusions for generated, lock, and build artifacts. This ensures the analysis focuses only on source code changes where FP improvements are relevant and actionable.

When should I not use functional programming refactoring on my code?

Functional programming review reports tradeoffs and identifies when FP would be a regression. It routes deep questions to type, effects, or verification subagents to ensure functional changes genuinely improve code quality rather than introducing unnecessary complexity.

What is the best way to analyze exhaustiveness and error handling in a git range diff?

Analyzing exhaustiveness and error handling in a git range diff uses targeted review modes that produce severity-labeled findings with file:line references. It automatically delegates deep type and effect questions to specialized subagents for thorough verification.