hmos-code-review

Reviews HarmonyOS ArkTS code changes and produces prioritized P0/P1/P2 review reports.

Updated Sep 3, 2026
One-click install
npx skills add https://github.com/YrracOwl/dsh-hmos-sidebar --skill hmos-code-review-yrracowl
Or copy as Structured Prompt for Agent
Please help me install this Agent Skill.
Skill: hmos-code-review
Source: https://github.com/YrracOwl/dsh-hmos-sidebar/tree/main/packages/dsh-hmos-sidebar/presets/native-harmonyos/skills/hmos-code-review
Command: npx skills add https://github.com/YrracOwl/dsh-hmos-sidebar --skill hmos-code-review-yrracowl

SYSTEM DOCUMENTATION & REQUIREMENTS

What problem does it solve? HarmonyOS code changes can pass static checks yet still contain logic errors, state management mistakes, resource leaks, and security issues that machines cannot catch. This Skill provides a structured review workflow that gates delivery quality before build and UI verification. ## Core Features & Use Cases - Machine-check-first workflow: Runs dcli__lsp_check and dcli__check_lint to zero diagnostics before any manual review begins. - Nine-dimension review checklist: Covers requirement coverage, logic correctness, state management (V1/V2 decorators), performance, lifecycle resources, error handling, security/permissions, engineering conventions, and maintainability. - Graded review reports: Produces P0 (blocking), P1 (must fix), and P2 (suggestion) findings with file locations and fix recommendations, plus mandatory re-verification after fixes. - Independent subagent review: Dispatches fresh-context subagents for complex features to eliminate blind spots from long development sessions. - Use Case: After implementing a new ArkTS page with state management, run this review to catch @Watch infinite loops, missing aboutToDisappear cleanup, and hardcoded strings before UI verification. ## Quick Start Review my recent HarmonyOS changes against the feature contract and produce a P0/P1/P2 code review report.

Frequently Asked Questions about hmos-code-review

High-intent search queries and answers about installing and using this skill.

FAQPage Schema
How do I review HarmonyOS ArkTS code before delivery?

Run dcli__lsp_check on changed files until diagnostics reach zero, optionally run dcli__check_lint, then review against the nine-dimension checklist covering logic, state management, performance, lifecycle, and security. Produce a P0/P1/P2 report and re-verify after fixes.

What should a HarmonyOS code review checklist include?

The checklist covers requirement coverage against acceptance contracts, boundary conditions and async races, V1/V2 decorator consistency, build() performance and LazyForEach usage, aboutToAppear/aboutToDisappear pairing, error handling with hilog, permission minimization, and naming conventions.

Does passing lsp_check mean HarmonyOS code is ready to ship?

No. LSP and lint checks only catch compile-level issues and are the entry ticket, not the review itself. Design, logic, boundary, and resource problems require manual review against the checklist before build and UI verification.

When should I use a subagent for independent code review?

Use a subagent for complex features or after long development sessions, since a fresh context avoids the blind spots of the main session. Provide it with file paths, acceptance contracts, and engineering conventions, then cross-check its findings for false positives.

What is the difference between P0, P1, and P2 review findings?

P0 findings block delivery and must be fixed, P1 findings should be fixed before release, and P2 findings are suggestions or future optimizations that do not block delivery. All P0 and P1 fixes require re-verification with lsp_check and a diff re-review.