implementation-final-review

Audits implementation diffs with fingerprinted independent reviews before final verification.

3.7k|945|Updated May 31, 2025
One-click install
npx skills add https://github.com/openai/openai-agents-js --skill implementation-final-review
Or copy as Structured Prompt for Agent
Please help me install this Agent Skill.
Skill: implementation-final-review
Source: https://github.com/openai/openai-agents-js/tree/main/.agents/skills/implementation-final-review
Command: npx skills add https://github.com/openai/openai-agents-js --skill implementation-final-review

SYSTEM DOCUMENTATION & REQUIREMENTS

💡 This Skill includes scripts (resource) and references (resource) components.

What problem does it solve?

It prevents premature completion of behavior-impacting code changes by enforcing a risk-tiered, independent final review of the complete task diff before final verification, catching contract, concurrency, security, and compatibility defects that self-review misses.

Core Features & Use Cases

  • Deterministic Review State Fingerprinting: Computes combined, per-component, and repository content fingerprints from the merge-base three-dot diff, including untracked task-owned files, so reviewers audit exactly one frozen state.
  • Independent Two-Reviewer Protocol: Dispatches two reviewers without inherited conversation history, validates their structured JSON outputs against an exact schema, and tracks findings by stable root-cause IDs in a task-global ledger.
  • Component-Aware Clean Credit: Partitions the diff into semantic components (e.g., public-api, session-persistence, provider-adapters) so unchanged components keep clean credit while changed ones get delta reviews.
  • Use Case: After implementing a change to the OpenAI Agents SDK that touches session persistence, run this review to build a reviewer packet, dispatch two independent reviewers on the frozen fingerprint, and only then run the full build and test gates.

Quick Start

Use $implementation-final-review to audit this implementation from first principles before calling it complete.

Frequently Asked Questions about implementation-final-review

High-intent search queries and answers about installing and using this skill.

FAQPage Schema
How do I run an independent final review on a code change before merging?

Resolve the merge base, generate review state with review_state.py using task and component pathspec files, build a reviewer packet, and dispatch two independent reviewers on the frozen fingerprint. Only after clean review do you run the full build and test gates.

What is a content fingerprint in a code review workflow?

A content fingerprint is a SHA-256 digest over the resolved base and every task-owned workspace entry, including untracked files. It guarantees reviewers inspect exactly one immutable state, and any change to reviewed content invalidates the round.

When should this final review skill be invoked?

Invoke it only when explicitly requested or when repository instructions require it after behavior-impacting implementation work. It is not for ordinary iteration; policy sets allow_implicit_invocation to false.

Does the review require clean git submodules?

Yes. Every initialized submodule, including nested ones, must be clean and checked out at the commit recorded by its parent index before fingerprinting. Dirty worktrees, unmerged index stages, and cyclic submodule graphs cause the review state capture to fail closed.

Why does reviewer output get rejected by the protocol validator?

review_protocol.py rejects outputs missing required schema fields, containing placeholder commands, duplicate JSON keys, non-finite numbers, or fingerprints that do not match the frozen packet. Every probe must record the exact executable command that ran.

Can unchanged components keep their clean review credit after a fix?

Yes. Components whose fingerprint, requirement rows, behavior assertions, dependency inputs, and risk tier are unchanged retain clean credit. Only changed or dependency-invalidated components require two concurrent independent delta reviews.