ironclaw-reborn-architecture-review

Reviews Rust crate changes for trait justification, dependency boundaries, and composition-layer placement.

12.6k|1.5k|Updated Feb 3, 2026
One-click install
npx skills add https://github.com/nearai/ironclaw --skill ironclaw-reborn-architecture-review
Or copy as Structured Prompt for Agent
Please help me install this Agent Skill.
Skill: ironclaw-reborn-architecture-review
Source: https://github.com/nearai/ironclaw/tree/main/.claude/skills/ironclaw-reborn-architecture-review
Command: npx skills add https://github.com/nearai/ironclaw --skill ironclaw-reborn-architecture-review

SYSTEM DOCUMENTATION & REQUIREMENTS

💡 This Skill includes references (resource) components.

What problem does it solve?

Rust monorepos decay through speculative abstractions and mass pooling inside crates that automated boundary tests cannot detect. This Skill gives reviewers a six-point checklist to catch unjustified traits, misplaced composition code, unenforced re-exports, and file sprawl before they merge.

Core Features & Use Cases

  • Trait Audit: Rejects single-implementation traits unless they enforce a verifiable dependency boundary, with live exemplars like RootFilesystem and SkillInferencePort.
  • Placement & Dependency Checks: Verifies new code in ironclaw_composition is wiring only, and that new crates get boundary rules added to ironclaw_architecture_tests in the same PR.
  • Worked Examples Reference: Ships a living curriculum of good/bad before-after shapes (sealed traits, re-export facades, backend parity) with commands to re-verify each exemplar.
  • Use Case: When a PR adds a new trait or crate edge in crates/, run the checklist plus cargo test -p ironclaw_architecture_tests to confirm the abstraction earns its keep.

Quick Start

Review my pull request that adds a new trait and a dependency edge in crates/ against the Reborn architecture checklist.

Frequently Asked Questions about ironclaw-reborn-architecture-review

High-intent search queries and answers about installing and using this skill.

FAQPage Schema
How do I review a new trait in a Rust monorepo?

Demand a second production implementation or a verifiable dependency boundary before accepting any new trait. A trait with one real impl is ceremony; extracting it later from a concrete type is mechanical, so reject swap-later rationalizations.

How do I enforce crate dependency boundaries in Rust?

Use a dedicated architecture test crate such as ironclaw_architecture_tests with explicit boundary rules per crate. Blocklist-based rules leave new crates unruled by default, so add the new crate's boundary rule in the same PR that introduces it.

When is a re-export between Rust crates justified?

A cross-crate re-export is justified only when a boundary test closes the direct import path and the re-export names its consumer and enforcing test. Glob re-exports at a crate root are treated as laundering and rejected.

What code belongs in a composition root crate?

Only service-graph wiring such as build_* and with_* functions belongs in the composition crate. Behavior like delivery logic, auth flows, or domain services belongs in an owning crate, following the ironclaw_webui host-side product crate model.

Why do architecture boundary tests pass while the codebase still decays?

Boundary tests police dependency edges, not interior mass or abstraction quality. The two real decay modes are mass pooling inside a crate and speculative abstraction, which require manual checklist review beyond the automated tests.