karenina-adapter-review

Reviews new karenina adapters for code quality, convention compliance, and correctness before merge.

13|3|Updated Jun 27, 2025
One-click install
npx skills add https://github.com/biocypher/karenina --skill karenina-adapter-review-biocypher
Or copy as Structured Prompt for Agent
Please help me install this Agent Skill.
Skill: karenina-adapter-review
Source: https://github.com/biocypher/karenina/tree/main/skills/karenina-adapter-review
Command: npx skills add https://github.com/biocypher/karenina --skill karenina-adapter-review-biocypher

SYSTEM DOCUMENTATION & REQUIREMENTS

What problem does it solve? New karenina adapters can pass cold tests while hiding bugs that only appear with live API calls, and they can drift from project conventions. This Skill provides a structured final review phase that catches quality, correctness, and convention issues before an adapter is merged. ## Core Features & Use Cases - Convention and code quality checks: Verifies file size limits, lazy import patterns, __all__ exports, no cross-adapter imports, and CLAUDE.md style rules such as PEP 604 unions and Google-style docstrings. - Hot-test-proven correctness checks: Validates structured output JSON serialization, max_turns wiring, timeout handling on all execution paths, MCP session lifecycle, and partial-result recovery on timeouts. - Registration and regression verification: Confirms AdapterRegistry registration, plugin entry points, full test suite passage, and a minimum hot test set (H1, H2, H5, H6, H8, H9) with live API calls. - Use Case: After implementing and testing a new LangGraph adapter for karenina, run this review to verify it honors timeouts, produces valid structured output, and complies with all project conventions before merging. ## Quick Start Review the new adapter at karenina/src/karenina/adapters/my-adapter against the review checklist and confirm it is ready to merge.

Frequently Asked Questions about karenina-adapter-review

High-intent search queries and answers about installing and using this skill.

FAQPage Schema
How do I review a new karenina adapter before merging?

Run the review checklist covering code quality, file size limits, lazy import patterns, registration verification, and convention compliance. Then run the full regression suite plus the minimum hot test set (H1, H2, H5, H6, H8, H9) with live API calls.

What hot tests must a karenina adapter pass?

The minimum set is H1 (simple query), H2 (real file read from workspace), H5 (LLMPort valid response with usage), H6 (ParserPort structured extraction), H8 (usage consistency across ports), and H9 (timeout returns partial result or raises AgentTimeoutError).

Can a karenina adapter import from other adapter packages?

No. Adapters must be self-contained; imports from other adapter packages are forbidden. Only imports from karenina.adapters.registry are allowed for registration, and shared utilities should be copied rather than imported across adapters.

Why does my adapter hang instead of timing out?

The timeout must wrap every execution path in asyncio.wait_for(), including no-tools fallback paths. Also verify max_turns is actually passed to the SDK's limit mechanism, such as LangGraph's recursion_limit, otherwise the agent runs indefinitely.

What happens when an adapter review check fails?

Fix the issue and re-run the specific check, repeating until all checks pass with a maximum of three iterations. If issues persist after three iterations, escalate to the user rather than continuing the revision loop.