kotlin-review

Review staged Kotlin and Java changes against repository coding guidelines and testing policy.

2|Updated May 28, 2021
One-click install
npx skills add https://github.com/SpineEventEngine/validation --skill kotlin-review-spineeventengine
Or copy as Structured Prompt for Agent
Please help me install this Agent Skill.
Skill: kotlin-review
Source: https://github.com/SpineEventEngine/validation/tree/main/.agents/skills/kotlin-review
Command: npx skills add https://github.com/SpineEventEngine/validation --skill kotlin-review-spineeventengine

SYSTEM DOCUMENTATION & REQUIREMENTS

What problem does it solve?

This Skill helps you avoid missed safety, quality, and testing issues by reviewing Kotlin (and Java) changes against the repository’s Spine coding guidelines before you open a PR.

Core Features & Use Cases

  • Guideline-driven review checklist: Verifies Kotlin idioms, formatting expectations, immutability, and prohibited patterns like unjustified !!.
  • Safety and compliance checks: Confirms constraints from safety rules (e.g., reflection approval requirements, no telemetry, no blocking calls in coroutines, and dependency bump policy).
  • Testing and version gate validation: Ensures functional changes have Kotest-based assertions with stubs (not mocks) and checks whether a user-visible version bump is required by the presence of a root version.gradle.kts.

Quick Start

Use the kotlin-review skill to review only the staged or changed files in this repository against .agents/ guidelines, focusing on Must fix, Should fix, and Nits, and then return an approval verdict.

Frequently Asked Questions about kotlin-review

High-intent search queries and answers about installing and using this skill.

FAQPage Schema
How do I review Kotlin code against repository-specific coding guidelines before a PR?

You can review staged or changed Kotlin and Java code against repository-specific guidelines, safety rules, and testing policy using a structured review process. It evaluates full affected file context and produces a structured assessment with Must fix, Should fix, and Nits categories.

What safety rules are checked during a Kotlin code review for PR readiness?

Safety rules checked during a Kotlin code review include reflection approval requirements, no telemetry, no blocking calls in coroutines, and dependency bump policy. It also verifies the absence of prohibited patterns like unjustified non-null assertions.

Does the code review enforce testing policy with Kotest for Kotlin changes?

Yes, the code review enforces testing policy by ensuring functional changes have Kotest-based assertions with stubs rather than mocks. It validates testing compliance as part of the PR readiness assessment.

How do I check if a version bump is required when reviewing Kotlin code changes?

To check if a version bump is required, the review process enforces a version gate when a root version.gradle.kts file exists in the repository. It validates whether user-visible version changes are needed based on the staged modifications.

Can I review Java and Kotlin code together for non-trivial edits before opening a PR?

Yes, you can review both Java and Kotlin code together for non-trivial edits and pre-PR checks. The review filters out config-distributed files and evaluates the full context of affected files to produce an approval verdict.

What is the best way to enforce coding guidelines and immutability in Kotlin PR reviews?

The best way to enforce coding guidelines and immutability is through a guideline-driven review checklist that verifies Kotlin idioms, formatting expectations, and prohibited patterns. It provides a structured assessment with quoted file and line evidence ending with an approval verdict.