maister:test-strategy-reviewer

Detect mismatches between test strategy and production code problem class.

40|39|Updated Apr 1, 2026
One-click install
npx skills add https://github.com/Architekt-Jutra/architekt-jutra-code --skill maister-test-strategy-reviewer
Or copy as Structured Prompt for Agent
Please help me install this Agent Skill.
Skill: maister:test-strategy-reviewer
Source: https://github.com/Architekt-Jutra/architekt-jutra-code/tree/main/week10/test-strategy-reviewer
Command: npx skills add https://github.com/Architekt-Jutra/architekt-jutra-code --skill maister-test-strategy-reviewer

SYSTEM DOCUMENTATION & REQUIREMENTS

What problem does it solve?

This Skill solves the common issue of mismatched test strategies, where tests use the wrong approach for the type of code they are validating — such as using output-based tests on integration code, interaction-based tests on pure transformations, or missing state verification on stateful objects. This leads to fragile, low-value tests that break on harmless refactors and fail to catch real regressions.

Core Features & Use Cases

  • Problem Class Classification: Automatically classifies production code into transformation, stateful object, or integration problem classes to determine the appropriate testing approach.
  • Test Strategy Mismatch Detection: Identifies when current tests use the wrong strategy for the code's problem class, such as mocking pure transformation steps or only checking return values for stateful objects.
  • Actionable Recommendations: Provides specific guidance to align test strategy with problem class, including mock placement best practices, test level selection (aggregate vs facade), and separation of transformation and integration logic.
  • Use Case: For example, if you have a pure calculation function that you are testing with mocks on its internal steps, this Skill will flag the unnecessary mocks and recommend simple output-based testing instead.

Quick Start

Invoke the test-strategy-reviewer skill with the path to your test file or a description of the code you want reviewed to receive a test strategy mismatch analysis.

Frequently Asked Questions about maister:test-strategy-reviewer

High-intent search queries and answers about installing and using this skill.

FAQPage Schema
How do I align my test strategy with the problem class of my production code?

To align test strategy with problem class, you must classify your code as transformation, stateful object, or integration logic, then apply output-based, state verification, or interaction tests respectively to prevent fragile test suites.

Why do my unit tests break on harmless refactors when using mocks?

Unit tests break on harmless refactors when using interaction-based tests on pure transformation logic. Mocking internal steps of pure calculations creates fragile tests that should instead use simple output-based verification.

When do I need state verification instead of checking return values in tests?

State verification is needed when testing stateful objects or aggregates. Relying solely on return values for stateful code misses internal state regressions because the problem class requires verifying state mutations rather than just outputs.

What is the best way to determine mock placement in integration testing?

Mock placement in integration testing is determined by separating transformation and integration logic. Mocks should be placed at the boundaries of integration code rather than inside pure transformations to ensure tests validate actual state changes and outputs correctly.

How can I detect test strategy mismatches in my codebase?

Detect test strategy mismatches by classifying production code into problem classes and evaluating current tests. This flags issues like output-based tests on integration code or missing state verification on stateful aggregates, providing actionable recommendations to align strategies.