maister:test-strategy-reviewer

What problem does it solve?

This Skill solves the common issue of mismatched test strategies, where tests use the wrong approach for the type of code they are validating — such as using output-based tests on integration code, interaction-based tests on pure transformations, or missing state verification on stateful objects. This leads to fragile, low-value tests that break on harmless refactors and fail to catch real regressions.

Core Features & Use Cases

• Problem Class Classification: Automatically classifies production code into transformation, stateful object, or integration problem classes to determine the appropriate testing approach.
• Test Strategy Mismatch Detection: Identifies when current tests use the wrong strategy for the code's problem class, such as mocking pure transformation steps or only checking return values for stateful objects.
• Actionable Recommendations: Provides specific guidance to align test strategy with problem class, including mock placement best practices, test level selection (aggregate vs facade), and separation of transformation and integration logic.
• Use Case: For example, if you have a pure calculation function that you are testing with mocks on its internal steps, this Skill will flag the unnecessary mocks and recommend simple output-based testing instead.

Quick Start

Invoke the test-strategy-reviewer skill with the path to your test file or a description of the code you want reviewed to receive a test strategy mismatch analysis.