mobile-sdk-ios-pr-review

Reviews Salesforce Mobile SDK iOS pull requests for API breakage, credential safety, and localization gaps.

555|425|Updated Sep 6, 2011
One-click install
npx skills add https://github.com/forcedotcom/SalesforceMobileSDK-iOS --skill mobile-sdk-ios-pr-review
Or copy as Structured Prompt for Agent
Please help me install this Agent Skill.
Skill: mobile-sdk-ios-pr-review
Source: https://github.com/forcedotcom/SalesforceMobileSDK-iOS/tree/main/.prizm/presubmits/skills/mobile-sdk-ios-pr-review
Command: npx skills add https://github.com/forcedotcom/SalesforceMobileSDK-iOS --skill mobile-sdk-ios-pr-review

SYSTEM DOCUMENTATION & REQUIREMENTS

What problem does it solve?

Reviewing pull requests against a public open-source iOS SDK requires checking backward compatibility, OAuth credential safety, SQLCipher encryption correctness, multi-user account handling, and localization discipline — checks that are easy to miss manually and costly when a breaking change ships to external developers via CocoaPods or Swift Package Manager.

Core Features & Use Cases

  • Eight review lenses: Covers public-API backward compatibility (with a deprecation-cycle matrix based on target branch and version), OAuth/token/credential safety, SQLCipher/SmartStore encryption, multi-user account correctness, localization, iOS platform hygiene, sample-app contract alignment, and test correctness.
  • Evidence-gated findings: Only reports issues when an old contract, new behavior, affected consumer path, and exact diff line can all be named, keeping reviewer noise low.
  • Structured JSON output: Emits findings with severity, confidence score, file path, and the exact offending line, suitable for presubmit pipelines and local review sessions.
  • Use Case: A contributor opens a PR that renames a public RestClient method and adds a hardcoded alert string. The skill flags the API break against the deprecation policy and the missing Localizable.strings entry, each with a grounded rationale.

Quick Start

Ask the reviewer to review the current pull request diff against the Salesforce Mobile SDK iOS review lenses and return JSON findings.

Frequently Asked Questions about mobile-sdk-ios-pr-review

High-intent search queries and answers about installing and using this skill.

FAQPage Schema
How do I review a Salesforce Mobile SDK iOS pull request for breaking changes?

Run the review against the PR diff; it checks public Swift and Objective-C API changes against a deprecation matrix based on the target branch (dev vs master) and the version in configuration/Version.xcconfig. Breaking changes are only permitted on dev when building toward a major X.0.0 release.

What does this PR reviewer check in iOS SDK code?

It applies eight lenses: public-API backward compatibility, OAuth and credential safety, SQLCipher/SmartStore encryption, multi-user account correctness, localization, iOS platform hygiene, sample-app contract alignment, and test correctness. Each finding must cite an exact changed line.

Does the reviewer flag deprecations in Objective-C headers?

Yes. Objective-C deprecations must use the SFSDK_DEPRECATED macro with deprecation and removal versions; raw __attribute__((deprecated)) or DEPRECATED_MSG_ATTRIBUTE usage is flagged. Removing a deprecated symbol is only allowed in a major release cycle.

When does the reviewer stay silent instead of commenting?

It stays silent when changes touch internal or private symbols, add optional parameters with defaults, are clean cherry-picks to master, or when no affected consumer path can be named. Findings below confidence 7.0 are never emitted.

What severity levels does the review output use?

Default findings are severity warning at confidence 7.0-10.0. Blocker severity is reserved for catastrophic cases like credential leak paths, SmartStore migrations that corrupt encrypted user data, or real secrets committed in test fixtures.