named-persona-adversarial-review

Reviews code through sourced engineering philosophies of named engineers like Torvalds, Thompson, and Carmack.

25.3k|3.6k|Updated Oct 19, 2025
One-click install
npx skills add https://github.com/alirezarezvani/claude-skills --skill named-persona-adversarial-review
Or copy as Structured Prompt for Agent
Please help me install this Agent Skill.
Skill: named-persona-adversarial-review
Source: https://github.com/alirezarezvani/claude-skills/tree/main/engineering-team/skills/named-persona-adversarial-review
Command: npx skills add https://github.com/alirezarezvani/claude-skills --skill named-persona-adversarial-review

SYSTEM DOCUMENTATION & REQUIREMENTS

💡 This Skill includes references (resource) components.

What problem does it solve?

Abstract adversarial code review produces generic findings because the model imagines what a reviewer might say. This Skill grounds each review lens in a real, documented engineering philosophy with named sources and confidence levels, producing findings you can cite and defend instead of vague role-play.

Core Features & Use Cases

  • Sourced persona lenses: Review code through documented principles from Torvalds, Thompson, Carmack, Beck, Brooks, Jobs, Cagan, and Traynor, each with a confidence level (high/moderate/low) recorded in references/persona_principles.md.
  • Anti-fabrication discipline: Every finding must cite a real principle with a confidence level; personas that cannot be grounded are dropped rather than given invented quotes.
  • Structured severity and routing: Findings are classified as BLOCKER/CRITICAL/WARNING/NOTE with concurrence-based promotion, and a routing table maps problem types (security, performance, architecture, docs) to the right persona mix.
  • Use Case: Before merging a PR that touches authentication logic, run a named-persona review so Torvalds' "good taste" principle flags special-case branching and Thompson's trust-boundary lens flags unvalidated third-party input, each with a cited source.

Quick Start

Review this pull request using named-persona adversarial review with Torvalds, Thompson, and Jobs, citing documented principles and confidence levels for every finding.

Frequently Asked Questions about named-persona-adversarial-review

High-intent search queries and answers about installing and using this skill.

FAQPage Schema
How do I review a PR using named engineering personas?

Pick personas per the routing table (default: Torvalds, Thompson, Jobs), ground each in their documented principles from references/persona_principles.md before reading code, then have each produce findings mapped to a principle with a confidence level. Synthesize duplicates, promote concurrent findings, and post the report as a PR comment.

What is the difference between named-persona review and abstract adversarial review?

Abstract adversarial review uses generic roles like 'saboteur', which produces surface-level findings. Named-persona review anchors each lens in a real, sourced philosophy (e.g., Thompson's Reflections on Trusting Trust), so findings cite a defensible principle rather than an imagined opinion.

How does the skill prevent fabricated quotes from real engineers?

It enforces an attribution discipline: cite the documented principle with a confidence level (high/moderate/low) instead of inventing verbatim quotes. If a persona's lens cannot be grounded in references/persona_principles.md or a verifiable source, that persona is dropped from the round.

Which personas should I use for security or performance reviews?

For security and supply chain, use Thompson plus Torvalds plus Cagan. For performance, use Carmack plus Torvalds plus Jobs. The routing table in SKILL.md maps problem types to persona mixes, and a product persona is mandatory in every round.

When should I not use named-persona adversarial review?

Skip it for cosmetic or low-impact PRs (use the simpler adversarial-reviewer instead), for throwaway prototype code, and when you have no web access and the persona is not covered in references/persona_principles.md, since ungrounded personas must not be used.

How many review rounds does a pull request need?

One round minimum for any PR. If BLOCKER or CRITICAL findings appear, fix them and run one re-review round. Two consecutive clean rounds end the process, and a single clean round suffices for low-impact PRs.