skills.rest
netalertx
netalertxOFFICIAL
Explore all skills by this author →
𝕏@NetAlertXGitHub

netalertx-pr-analysis

Analyzes GitHub PR review comments and guides compliant code changes and replies.

7.0k|426|Updated Dec 23, 2021
Search Tags:#Testing#gitHub#netalertx#commit workflow#comment triage#Code review#Pull request
One-click install
npx skills add https://github.com/netalertx/NetAlertX --skill netalertx-pr-analysis
Or copy as Structured Prompt for Agent▼
Please help me install this Agent Skill.
Skill: netalertx-pr-analysis
Source: https://github.com/netalertx/NetAlertX/tree/main/.github/skills/pr-analysis
Command: npx skills add https://github.com/netalertx/NetAlertX --skill netalertx-pr-analysis

SYSTEM DOCUMENTATION & REQUIREMENTS

What problem does it solve?

Handling pull request review feedback in NetAlertX requires consistent conventions for tests, MAC address formatting, helper reuse, and reply etiquette; this Skill enforces those rules so every PR comment is classified, acted on, and answered correctly.

Core Features & Use Cases

  • Comment Classification: Sorts each review comment into code-change requests, questions, suggestions, or general feedback, with a defined action for each type.
  • Test-Writing Guardrails: Enforces a non-negotiable checklist before touching test/ files, including lowercase MAC literals, shared helpers from test/db_test_helpers.py, mirrored test directory structure, and top-of-file imports.
  • Structured Reply Workflow: Requires loading related skills (code-standards, testing-workflow), running targeted tests, and replying with the short commit hash only after changes are pushed.
  • Use Case: When a reviewer leaves inline comments on a NetAlertX PR targeting next_release, use this Skill to triage each comment, make focused commits, verify with grep checks and secret scanning, and post concise replies.

Quick Start

Analyze the open review comments on my NetAlertX pull request and tell me which ones require code changes, then apply each fix following the project test conventions.

Frequently Asked Questions about netalertx-pr-analysis

High-intent search queries and answers about installing and using this skill.

FAQPage Schema
How do I respond to GitHub PR review comments in NetAlertX?▼

Classify each comment first: code-change requests get implemented and validated, questions get concise answers, actionable suggestions get acted on, and general praise gets no reply. Reply only after the commit is pushed, including the short commit hash.

How should I write tests for NetAlertX code changes?▼

Place new tests in a subdirectory of test/ mirroring the source path, reuse factories like make_db and insert_device_from_dict from test/db_test_helpers.py, keep all imports at the top of the file, and write all MAC address literals in lowercase hex.

Why must MAC addresses be lowercase in NetAlertX tests?▼

The project convention requires every MAC string in fixtures, parametrize blocks, assertions, and comments to be lowercase hex such as aa:bb:cc:dd:ee:01. You can verify compliance by running grep -Pn '[0-9A-F]{2}:[0-9A-F]' test/ and confirming the output is empty.

What should I do when a NetAlertX PR targets a non-default branch?▼

Do not retarget the branch yourself; note the issue in a reply so the author can change the base branch from the GitHub UI. Also check CI failures on the base branch, such as next_release, before investigating failures on your own branch.

When should I not reply to a PR review comment?▼

Do not reply to general comments or praise, and skip suggestions you determine are not actionable. Replies should be concise, state what was done, include the short commit hash when relevant, and avoid thanking the reviewer.

Related Skills

Explore More Software Engineering Skills→
netalertxnetalertx
6.9k

netalertx-code-standards

Enforce NetAlertX coding standards during development and code reviews.

Official
Basic
mvillmowmvillmow
18

gh-fix-pr-feedback

Fetch GitHub PR review comments, implement changes, and reply to each comment.

Community
Basic
AfaneorAfaneor
77

secret-scanner

Detect hardcoded secrets in staged changes and block risky commits.

Community
Basic
grimlorgrimlor
2

feature-workflow

Enforce a spec-before-code workflow with gated checkpoints and BDD tests.

Community
Advanced