pocock-review

Reviews a git diff against coding standards and the originating spec using parallel sub-agents.

2|Updated Apr 2, 2026
One-click install
npx skills add https://github.com/nseng-ai/ns --skill pocock-review-nseng-ai
Or copy as Structured Prompt for Agent
Please help me install this Agent Skill.
Skill: pocock-review
Source: https://github.com/nseng-ai/ns/tree/main/.agents/skills/pocock-review
Command: npx skills add https://github.com/nseng-ai/ns --skill pocock-review-nseng-ai

SYSTEM DOCUMENTATION & REQUIREMENTS

What problem does it solve? Code review often conflates two separate questions — whether code follows project conventions and whether it implements what was actually requested — letting one axis mask failures in the other. This Skill separates those concerns into two independent reviews of the same diff. ## Core Features & Use Cases - Two-axis review: Runs a Standards review (documented repo standards plus a Fowler code-smell baseline) and a Spec review (requirements from the originating issue or spec file) as parallel sub-agents that don't pollute each other's context. - Fixed-point diffing: Reviews changes since any commit, branch, tag, or merge-base using three-dot git diff, with upfront validation that the ref resolves and the diff is non-empty. - Spec discovery: Locates the originating spec from issue references in commit messages, user-provided paths, or spec files under docs/, specs/, or .scratch/. - Use Case: Before merging a feature branch, ask for a review since main — you get a Standards report citing violated conventions and code smells, plus a Spec report listing missing requirements and scope creep, reported side by side. ## Quick Start Ask the agent to review the changes since main on the current branch against the repo's coding standards and the originating issue.

Frequently Asked Questions about pocock-review

High-intent search queries and answers about installing and using this skill.

FAQPage Schema
How do I review changes since a specific commit or branch?

Provide a fixed point such as a commit SHA, branch name, tag, or HEAD~5, and the review compares it against HEAD using a three-dot git diff from the merge-base. If you don't specify one, the skill asks for it before proceeding.

How does a standards vs spec code review work?

Two parallel sub-agents review the same diff independently: one checks documented repo standards plus a Fowler code-smell baseline, the other checks the diff against the originating issue or spec. Findings are reported under separate headings so one axis can't mask the other.

What code smells does the review check for?

The baseline covers twelve Fowler smells including Duplicated Code, Feature Envy, Data Clumps, Primitive Obsession, Shotgun Surgery, and Speculative Generality. Each is treated as a judgement call, and documented repo standards always override the baseline.

What happens if there is no spec for the changes?

The skill searches commit messages for issue references, user-provided paths, and spec files under docs/, specs/, or .scratch/. If none exists, the Spec sub-agent is skipped and the final report notes that no spec was available.

Why does the review fail before starting the sub-agents?

The fixed point is validated upfront with git rev-parse and the diff is checked for emptiness. A bad ref or empty diff fails immediately rather than surfacing inside the parallel sub-agents.