pr-review-non-negotiables

Applies eleven hard-gate review criteria to every pull request or diff review.

Updated May 21, 2026
One-click install
npx skills add https://github.com/CagesThrottleUs/private-ai-harness --skill pr-review-non-negotiables-cagesthrottleus
Or copy as Structured Prompt for Agent
Please help me install this Agent Skill.
Skill: pr-review-non-negotiables
Source: https://github.com/CagesThrottleUs/private-ai-harness/tree/main/skills/pr-review-non-negotiables
Command: npx skills add https://github.com/CagesThrottleUs/private-ai-harness --skill pr-review-non-negotiables-cagesthrottleus

SYSTEM DOCUMENTATION & REQUIREMENTS

What problem does it solve? Code reviews often vary in rigor depending on the reviewer or tool, letting regressions in compatibility, performance, security, or testing slip through silently. This Skill defines a fixed set of hard gates that every PR review must check, so no critical dimension is skipped without an explicit justification. ## Core Features & Use Cases - Eleven mandatory review gates: backward compatibility, migration via expand-contract, performance, reuse, testing, security, why/ROI, user experience, determinism, over/underengineering balance, and compatibility matrix coverage. - Tool-agnostic application: applies whether the review runs through pr-reviewer, giving-code-review, requesting-code-review, scout-pr-review, or an ad-hoc manual review. - Layering with repo policy: acts as a meta layer above repo-specific policies like .scout/review-policy.md, which can add detail but never override a non-negotiable. - Use Case: While reviewing a PR that removes a legacy API endpoint, the reviewer flags it as a finding because there is no expand phase and no verified-zero-usage check before the old path is removed. ## Quick Start Review this pull request against the PR review non-negotiables checklist and report any gate that fails or is not applicable.

Frequently Asked Questions about pr-review-non-negotiables

High-intent search queries and answers about installing and using this skill.

FAQPage Schema
How do I make code reviews consistent across different reviewers and tools?

Apply a fixed non-negotiables checklist to every review regardless of tool. This Skill defines eleven hard gates covering compatibility, migration, performance, testing, security, and design balance that must each be checked or explicitly marked not applicable.

What is the expand-contract pattern for breaking changes?

Expand-contract (parallel change) adds the new path alongside the old one, migrates callers and data until old-path usage hits zero, then removes the old path. A change that removes the old path without a verified-zero-usage check is flagged as a finding.

Does this checklist work with scout-pr-review and repo review policies?

Yes. It acts as a meta layer above repo-specific policies like .scout/review-policy.md. Repo policy can add detail during scout-pr-review phases, but it can never override one of the eleven non-negotiable gates.

How should tests be judged during a PR review?

Judge tests by whether they would catch a real regression in CI, not by whether a test merely exists. Coverage must be detailed enough that a regression on the changed behavior surfaces in CI rather than in production.

When is a new abstraction flagged as overengineering?

An abstraction is flagged when it fails the YAGNI bar: if it could be added cheaply via refactor when a second real caller appears, the premature version is a finding. Speculative flexibility and unused generalization are flagged just like missing structure.