quality-review

Reviews Java code against SOLID, packaging, and testability conventions and produces a structured findings report.

Updated Jun 25, 2026
One-click install
npx skills add https://github.com/oriddd/ai-toolkit --skill quality-review-oriddd
Or copy as Structured Prompt for Agent
Please help me install this Agent Skill.
Skill: quality-review
Source: https://github.com/oriddd/ai-toolkit/tree/main/copilot/public/skills/quality-review
Command: npx skills add https://github.com/oriddd/ai-toolkit --skill quality-review-oriddd

SYSTEM DOCUMENTATION & REQUIREMENTS

What problem does it solve? Before opening a pull request or refactoring legacy code, developers need a consistent, evidence-based check that their Java code follows the project's SOLID principles, packaging rules, and testability standards. This Skill runs a structured review and produces a report of violations with concrete fix suggestions, instead of relying on ad-hoc manual review. ## Core Features & Use Cases - SOLID and packaging audit: Checks SRP, OCP, LSP, ISP, DIP, lego-brick package hierarchy, and external-client wrapping rules with cited line numbers as evidence. - Cross-cutting convention checks: Flags exception handling, logging, constants, concurrency, reactive boundary, and configuration violations against project conventions. - Test quality and testability analysis: Detects meaningless assertions, missing negative-path tests, static business logic, global state, hidden dependencies, and constructor side effects, plus quantitative thresholds (complexity, method length, coverage). - Use Case: Before opening a PR, run the review on your changed files to get a PASS/FAIL/WARN report per checklist item, a summary of top fixes, and pointers to the follow-up skills that apply each fix. ## Quick Start Ask the AI to run the quality-review skill on the current class or changed files and produce the structured findings report before opening the pull request.

Frequently Asked Questions about quality-review

High-intent search queries and answers about installing and using this skill.

FAQPage Schema
How do I review Java code for SOLID principle violations?

Run this review on a class, package, or diff to check SRP, OCP, LSP, ISP, and DIP with concrete smells and fix templates. Each finding cites line numbers and references the canonical pattern, such as extracting a Strategy plus Registry for switch-based type discrimination.

How to check test quality and coverage in a Spring Boot project?

The review verifies every public method has happy-path, exception, branch, and boundary tests, flags assertNotNull-only assertions, and checks naming conventions. It also enforces Jacoco thresholds of 85 percent line and 75 percent branch coverage per class.

Does this code review skill modify my source code?

No, it only produces a structured report of findings with suggested fixes. The developer accepts or rejects each finding and applies changes through dedicated skills such as external-client, exception-handling, or unit-tests.

What testability anti-patterns does static analysis detect in Java?

It flags static methods containing business logic, global mutable state and singletons, hidden dependencies like System.getenv, time logic without an injected Clock, direct file or network I/O in services, and constructors performing I/O or heavy work.

When should I run a quality review during development?

Run it before opening a pull request on the diff, when onboarding a legacy class to project conventions, or during design review of a new package. Ambiguous findings are marked WARN rather than FAIL so the reviewer decides.