questioning-hardcoded-values

To identify and document magic numbers during code review, systematically question every hardcoded literal value. Replace unexplained numbers with named constants and document the specific calculation or assumption justifying that exact value.

Justifying hardcoded values in source code involves ensuring every literal answers "why this specific value?" through documented conventions and verified assumptions, replacing ambiguity with clear, maintainable named constants.

Reviewing unexplained literal values requires scanning the snippet for hardcoded strings and numbers, then prompting the author to define named constants with explanatory documentation to prevent bugs and ensure maintainability.

You need to replace hardcoded numbers with named constants whenever a literal value lacks an immediate explanation, ensuring the calculation or assumption behind the value is verified and documented for future maintainability.

Questioning hardcoded strings and magic numbers prevents bugs and improves maintainability by eliminating ambiguity. It ensures unexplained assumptions are verified and documented, making the source code logic clear for future developers.

Yes, this code review approach works for any programming language because questioning hardcoded literal values, defining named constants, and verifying assumptions are universal practices for improving source code quality and maintainability.