reader-protocol-pr-review

Reviews pull requests touching the Reader's social, atmosphere, and mastodon protocol surfaces.

12.6k|2.0k|Updated Nov 10, 2015
One-click install
npx skills add https://github.com/Automattic/wp-calypso --skill reader-protocol-pr-review
Or copy as Structured Prompt for Agent
Please help me install this Agent Skill.
Skill: reader-protocol-pr-review
Source: https://github.com/Automattic/wp-calypso/tree/main/.claude/skills/reader-protocol-pr-review
Command: npx skills add https://github.com/Automattic/wp-calypso --skill reader-protocol-pr-review

SYSTEM DOCUMENTATION & REQUIREMENTS

💡 This Skill includes references (resource) components.

What problem does it solve?

Reviewing PRs in the Reader's multi-protocol social territory (atmosphere, mastodon, shared post-card components) repeatedly surfaces the same bugs — cross-tenant cache poisoning, missing default arms, silent no-ops — and reviewers waste effort rediscovering them each slice cycle.

Core Features & Use Cases

  • Structured review rubric: Produces severity-tagged findings (blocker/important/nit) with file:line anchors, in-PR vs follow-up classification, and a verdict line, capped at ~700 words.
  • Recurring-smell checklist: Ships a catalog of 9+ concrete findings from the CM-625/658/660/662 slice cycle, covering optimistic-mutation scoping, cancelQueries wrapping, encodeURIComponent on wire IDs, and error-observability gaps.
  • Cross-PR fix propagation: Guides checking sibling slice PRs for the same defect after a fix lands on one, since the atmosphere and mastodon architectures mirror each other.
  • Use Case: When a PR modifies packages/api-queries/src/reader-mastodon.ts, walk the smell checklist to verify the optimistic patcher is connection-scoped and cancelQueries is wrapped in try/catch before approving.

Quick Start

Review PR number 1234 in wp-calypso using the reader protocol review rubric and the common-smells checklist.

Frequently Asked Questions about reader-protocol-pr-review

High-intent search queries and answers about installing and using this skill.

FAQPage Schema
How do I review a Reader protocol PR in wp-calypso?

Apply the severity-tagged rubric (blocker, important, nit) with file:line anchors, then walk the common-smells checklist covering optimistic patchers, cancelQueries wrapping, and error-message default arms. Cap the review at roughly 700 words and end with an approve or request-changes verdict.

What are common bugs in optimistic mutations with TanStack Query?

Recurring issues include cross-tenant cache poisoning when patchers walk all queries without connection scoping, unwrapped cancelQueries calls that can swallow the mutation, and missing onSettled reconciliation that lets optimistic counts drift.

When should I dispatch the code-reviewer agent for a PR?

Dispatch it when the PR exceeds 20 files or 500 lines, when it mirrors a sibling PR already reviewed, or when you authored adjacent code and want an independent read. Brief it with the PR number, branch, purpose, and the recurring smells to check.

Why must wire IDs be wrapped in encodeURIComponent in fetchers?

Path-interpolated IDs that are URL-safe today can become unsafe after a mapper bug or validator widening, smuggling extra path segments into the request. Wrapping every user-derived path segment in encodeURIComponent prevents this class of injection.

Which findings should be deferred to follow-up issues instead of blocking a PR?

Architectural changes spanning multiple slices belong in follow-ups, such as cross-component pending sentinels for Mastodon, onSettled reconciliation, schema validation on wire responses, and error logging upstream of the classifier. Cheap defensive fixes stay in the PR.