receiving-code-review

Evaluate and respond to code review feedback with verification and technical rigor.

18|8|Updated May 31, 2023

Search Tags:#code review #feedback #pull request #developer workflow #verification #technical rigor

Ready to run

npx skills add https://github.com/jpmorgan-payments/embedded-finance --skill receiving-code-review-jpmorgan-payments

💬 Prompt for ChatGPT / Claude Chat▼

Please help me install this Agent Skill.
Skill: receiving-code-review
Source: https://github.com/jpmorgan-payments/embedded-finance/tree/main/.github/skills/superpowers/receiving-code-review
Command: npx skills add https://github.com/jpmorgan-payments/embedded-finance --skill receiving-code-review-jpmorgan-payments

SYSTEM DOCUMENTATION & REQUIREMENTS

What problem does it solve?

This Skill helps you navigate code review feedback by ensuring you critically evaluate suggestions before implementing them, preventing unnecessary work and maintaining technical integrity.

Core Features & Use Cases

Structured Response Pattern: Follows a clear process: Read, Understand, Verify, Evaluate, Respond, Implement.
Handling Ambiguity: Provides clear steps for asking clarifying questions when feedback is unclear.
External Reviewer Scrutiny: Outlines specific checks for feedback from external sources, emphasizing verification against codebase reality and potential conflicts.
Use Case: When a reviewer suggests a change that seems unnecessary or potentially harmful, this skill guides you to ask probing questions and verify the impact before blindly accepting the suggestion.

Quick Start

When receiving code review feedback, verify its technical soundness against the codebase before implementing any suggestions.

Frequently Asked Questions about receiving-code-review

High-intent search queries and answers about installing and using this skill.

FAQPage Schema

How do I critically evaluate code review feedback before implementing changes?▼

To critically evaluate code review feedback, follow a structured response pattern: read, understand, verify, evaluate, respond, and implement. This process ensures you check technical soundness against the codebase before applying any suggestions.

What should I do when code review feedback is unclear or ambiguous?▼

When code review feedback is unclear, you should ask clarifying questions. This step ensures you fully understand the reviewer's intent and can verify the technical impact before making unnecessary or potentially harmful changes.

How do I handle pull request suggestions from external reviewers?▼

For pull request suggestions from external reviewers, apply specific scrutiny by verifying the feedback against codebase reality. Check for potential conflicts and ensure the changes align with project YAGNI principles before implementation.

Why should I verify code review suggestions instead of immediately accepting them?▼

Verifying code review suggestions prevents unnecessary work and maintains technical integrity. It ensures technical correctness and adherence to project YAGNI principles, avoiding performative agreement by prioritizing technical rigor over blindly accepting suggestions.

What is the best way to respond to a code review comment that seems unnecessary?▼

The best way to respond to an unnecessary code review comment is to ask probing questions and verify the impact. This approach helps you critically evaluate the suggestion's technical soundness before deciding whether to implement it.