receiving-code-review

Evaluate code review feedback with verification and reasoned pushback.

Updated Dec 22, 2024
One-click install
npx skills add https://github.com/lvstb/nix-config --skill receiving-code-review-lvstb
Or copy as Structured Prompt for Agent
Please help me install this Agent Skill.
Skill: receiving-code-review
Source: https://github.com/lvstb/nix-config/tree/main/home/opencode/skills/receiving-code-review
Command: npx skills add https://github.com/lvstb/nix-config --skill receiving-code-review-lvstb

SYSTEM DOCUMENTATION & REQUIREMENTS

What problem does it solve?

This Skill addresses the common pitfall of blindly accepting code review feedback without technical verification, ensuring that suggestions are technically sound, relevant to the codebase, and do not introduce regressions.

Core Features & Use Cases

  • Structured Response Pattern: Provides a clear, step-by-step process for handling feedback: Read, Understand, Verify, Evaluate, Respond, Implement.
  • Technical Rigor: Emphasizes technical correctness over performative agreement or social comfort.
  • Handling Ambiguity: Guides users on how to seek clarification for unclear feedback.
  • Source-Specific Guidance: Offers tailored approaches for feedback from project owners versus external reviewers.
  • YAGNI Check: Incorporates the "You Ain't Gonna Need It" principle to avoid unnecessary feature implementation.
  • Use Case: When a reviewer suggests a change, this Skill ensures you first verify its technical validity and impact on the existing codebase before implementing it, preventing the introduction of bugs or unnecessary complexity.

Quick Start

When receiving code review feedback, follow the verify-then-implement pattern.

Frequently Asked Questions about receiving-code-review

High-intent search queries and answers about installing and using this skill.

FAQPage Schema
How do I evaluate code review feedback before implementing changes?

Evaluate code review feedback by following a structured pattern: read, understand, verify, evaluate, respond, and implement. This ensures technical correctness and prevents regressions before you modify the codebase.

What is the best way to respond to pull request comments that seem unnecessary?

To respond to unnecessary pull request comments, apply the YAGNI principle to evaluate if the change is truly needed, then provide a reasoned pushback prioritizing technical rigor over performative agreement.

How should I handle code review feedback from external reviewers versus project owners?

Handle code review feedback by applying source-specific guidance tailored for external reviewers versus project owners, ensuring you verify technical validity and seek clarification for any ambiguous suggestions.

Why does blindly accepting code review feedback cause software development issues?

Blindly accepting code review feedback causes software development issues because it introduces regressions and unnecessary complexity without verifying technical soundness, relevance to the codebase, or adherence to YAGNI principles.

When do I need to seek clarification for code review suggestions?

You need to seek clarification for code review suggestions when encountering ambiguity, ensuring you fully understand the feedback before attempting to verify its technical validity or implementing any changes.