review-comet-pr

Review DataFusion Comet pull requests for Spark compatibility and implementation correctness.

Updated Aug 27, 2026
One-click install
npx skills add https://github.com/sp-202/datafusion-comet-geo --skill review-comet-pr-sp-202
Or copy as Structured Prompt for Agent
Please help me install this Agent Skill.
Skill: review-comet-pr
Source: https://github.com/sp-202/datafusion-comet-geo/tree/main/.claude/skills/review-comet-pr
Command: npx skills add https://github.com/sp-202/datafusion-comet-geo --skill review-comet-pr-sp-202

SYSTEM DOCUMENTATION & REQUIREMENTS

What problem does it solve?

It helps human reviewers catch behavioral mismatches between Apache Spark and Apache DataFusion Comet, reducing the chance that a PR lands with subtle correctness regressions.

Core Features & Use Cases

  • PR review guidance for correctness: Walks through collecting PR context, reading diffs, and focusing on Spark compatibility as the most critical requirement.
  • Spark-aligned implementation checks: Provides a workflow for expression PRs that includes reading the authoritative Spark source behavior (eval, null handling, types, ANSI mode).
  • Test and performance review support: Emphasizes using Comet SQL test suites for expression testing, checking edge cases, and validating that new expressions include performance evidence.

Quick Start

Review the PR by fetching its metadata, reading the changed files and diff, then using the workflow to compare the Comet implementation against Spark source behavior and recommend any missing tests or documentation updates.

Frequently Asked Questions about review-comet-pr

High-intent search queries and answers about installing and using this skill.

FAQPage Schema
How do I review a DataFusion Comet pull request for Spark compatibility?

Reviewing Spark compatibility in a pull request involves extracting PR metadata via GitHub CLI, reading changed files, and comparing Comet expression implementations against canonical Spark source behavior to catch correctness regressions early.

What is the best way to validate Spark expression behavior in a Comet PR?

Validating Spark expression behavior in a Comet PR requires reading the authoritative Spark source for eval and null handling, verifying serde registration, and running Comet SQL test suites to catch behavioral mismatches.

How does serde integration affect Spark compatibility checks in Comet?

Serde integration impacts Spark compatibility checks by requiring verification of serde registration and support levels to ensure Comet correctly maps Spark expression behavior and prevents correctness regressions.

Do I need to check ANSI mode differences when reviewing Comet SQL tests?

Yes, checking ANSI mode differences is necessary when reviewing Comet SQL tests because ANSI mode variations between Spark and Comet can cause subtle behavioral mismatches and correctness regressions in expression evaluation.

What limitations should I look for when validating null semantics in Spark compatibility?

When validating null semantics for Spark compatibility, look for limitations in how Comet handles null inputs compared to authoritative Spark source behavior, ensuring edge cases are covered by Comet SQL tests.

Can I automate CI checks and performance validation for DataFusion Comet PRs?

You can automate CI checks and performance validation for DataFusion Comet PRs by summarizing CI considerations and verifying that new expressions include performance evidence to ensure implementation correctness and Spark compatibility.