skills.rest
xiaolai
xiaolaiCOMMUNITY
Explore all skills by this author →
Website𝕏@xiaolaiGitHub

review-gate

Produces severity-ordered code review findings with test-quality and missing-test audits.

10|7|Updated Feb 23, 2026
Search Tags:#tdd#code review#test quality#coverage#severity findings#mock boundaries#specification strength
One-click install
npx skills add https://github.com/xiaolai/tdd-guardian-for-claude --skill review-gate-xiaolai
Or copy as Structured Prompt for Agent▼
Please help me install this Agent Skill.
Skill: review-gate
Source: https://github.com/xiaolai/tdd-guardian-for-claude/tree/main/skills/tdd-guardian/review-gate
Command: npx skills add https://github.com/xiaolai/tdd-guardian-for-claude --skill review-gate-xiaolai

SYSTEM DOCUMENTATION & REQUIREMENTS

What problem does it solve? Code reviews often bury critical issues under summaries and overlook weak tests that assert mock calls instead of real behavior. This Skill enforces a findings-first review format with a mandatory eight-check audit of test quality, specification strength, and lane assignment. ## Core Features & Use Cases - Findings-first output: Every review lists findings sorted by severity with file, line, risk, and concrete fix before any summary. - Test quality audit: Eight checks covering wiring-only tests, mock boundary violations, security verification via mock args, unreliable v8 ignore directives, unpaired mock boundaries, lane misassignment, under-specified units, and change-tax over-specification. - Use Case: After implementing a feature with tests, run a review that flags a security test verifying container config only through mock call arguments as High severity, and demands an integration test inspecting the real resource. ## Quick Start Review the current diff and produce a findings-first report including the full test quality audit.

Frequently Asked Questions about review-gate

High-intent search queries and answers about installing and using this skill.

FAQPage Schema
How do I review code for test quality issues?▼

Run a findings-first review that audits every touched test file across eight checks: wiring-only assertions, mock boundary violations, security verification via mock args, v8 ignore directives, unpaired mock boundaries, lane assignment, specification strength, and change tax.

What is a wiring-only test and why is it flagged?▼

A wiring-only test asserts only that mocks were called (Levels 6-7) without verifying return values, errors, output, or state. It is flagged as High severity because it proves nothing about observable behavior.

How are code review findings ordered and formatted?▼

Findings come first, sorted by severity, each with file, line, risk, and concrete fix. Test-quality and missing-test findings follow, then a short summary and residual risks.

Does this check coverage ignore comments like v8 ignore next?▼

Yes. It flags `/* v8 ignore next */` directives as High severity because they silently fail on `??`, ternaries, catch bodies, and short-circuit operators. The fix is to use `/* v8 ignore start */` and `/* v8 ignore stop */`.

What are the limitations of this review skill?▼

It defines only the review rubric and severity assignment. Assertion level definitions, specification levels S1-S6, lane placement rules, and coverage computation are delegated to the policy-core, lane-policy, and coverage-gate skills.

Related Skills

Explore More Software Engineering Skills→
TrevorPLamTrevorPLam

agent-tester

Analyze code diffs and coverage to generate and execute scoped tests.

Community
Advanced
evatt-harvey-salingerevatt-harvey-salinger

roborev:fix

Aggregate unaddressed code review findings and apply fixes by file.

Community
Advanced
wewetv1987-cellwewetv1987-cell

test-driven-development

Enforce test-first development with failing-test confirmation and red-green-refactor discipline.

Community
Advanced
pingfanfanpingfanfan
96

test-first

Guides test-driven development by writing failing tests before implementation.

Community
Basic