review-general

Reviews branch diffs against the merge base for bugs, sandbox escapes, and documentation gaps.

8.1k|413|Updated May 28, 2023
One-click install
npx skills add https://github.com/pydantic/monty --skill review-general
Or copy as Structured Prompt for Agent
Please help me install this Agent Skill.
Skill: review-general
Source: https://github.com/pydantic/monty/tree/main/.agents/skills/review-general
Command: npx skills add https://github.com/pydantic/monty --skill review-general

SYSTEM DOCUMENTATION & REQUIREMENTS

What problem does it solve?

Reviewing a branch before merge requires checking many risk categories at once, and it is easy to miss subtle issues like resource-limit escapes, CPython divergence, or documentation that fell out of sync. This Skill provides a structured checklist-driven review of the current branch against its merge base so findings are caught before merge.

Core Features & Use Cases

  • Scoped diff review: Starts with git diff --stat origin/main...HEAD to scope the change, then reads changed files in full rather than relying on hunks.
  • Multi-category findings: Checks for bugs, CPython divergence, sandbox escapes, resource-limit escapes, performance regressions, verbose comments, and missing limitations/ or docs updates.
  • Severity-ordered report: Produces a concise report with file:line, the concrete failure each finding causes, most severe first.
  • Use Case: Before merging a PR in the Monty repository, run this review to catch an unbounded String build that bypasses the allocation tracker or a new CPython divergence with no limitations/ entry.

Quick Start

Ask the assistant to run the general branch review on the current branch against origin/main and report any findings.

Frequently Asked Questions about review-general

High-intent search queries and answers about installing and using this skill.

FAQPage Schema
How do I review a git branch before merging a pull request?

Run git diff --stat origin/main...HEAD to scope the change, then git diff origin/main...HEAD and read the changed files in full. This Skill walks that process and checks each change against a fixed list of risk categories.

What issues does a general branch code review check for?

It checks for logic bugs, CPython divergence in results or exception types, sandbox escapes to the host filesystem or network, resource-limit escapes like untracked allocations, performance regressions, verbose comments, and missing limitations or docs updates.

How do I verify CPython divergence in a Python interpreter implementation?

Compare results, exception types, messages, and attributes against real CPython behavior. This Skill directs you to check anything uncertain with the python-playground tool rather than guessing.

What is a resource-limit escape in a sandboxed interpreter?

It is an allocation or computation not charged to the resource tracker, such as an unbounded String build without StringBuilder, an unbounded loop, or recursion without a depth guard. These let sandboxed code consume unlimited host resources.

Does this review fix the issues it finds?

No, it produces a report only, ordered by severity with file and line references and the concrete failure each issue causes. Fixes are applied only if the user explicitly asks for them.