review-hog-perspective-logic-correctness

Apply a dedicated correctness perspective that checks calculations, conditional branching, boundary conditions, and edge cases in the changed code. This Skill guides the review with investigation commands and key questions, reporting only correctness findings.

It catches incorrect algorithms, off-by-one errors, missing edge-case handling, wrong data transformations, SQL query-logic errors, and state-management bugs. Security vulnerabilities and performance issues are intentionally left to other review perspectives.

No, findings are raised only on non-test files. Test files are read for context when validating a finding in production code, since test code follows its own patterns and conventions.

Yes, one of its explicit checks is validating that synchronous SQL queries are not issued from an async context, which would block the event loop thread. It also reviews JOIN conditions, aggregations, and transaction boundaries.

It deliberately stays in its lane: performance, error-handling completeness, security, and API-contract changes are covered by separate perspectives. Overlap between perspectives is resolved later by a deduplication step.