review-oo-design

Run the review on the target package; it inventories types, builds a method×field cohesion matrix per type, and classifies every relationship as containment, association, or inheritance. Findings cite file:line evidence and must name a concrete cost before being reported.

The skill applies Riel's decision table: shared data only means containment, shared data and behaviour means a common base, and interface only means a base only if used polymorphically. It also runs the substitution test, where a subtype may only weaken preconditions and strengthen postconditions.

Yes, it loads a per-language paradigm mapping before reviewing, since Riel wrote for C++ and Smalltalk. In Go, embedding is treated as containment and inheritance heuristics are void; in Elixir, class-based heuristics are adapted or excluded entirely.

Yes, the function×parameter matrix finds abstractions that do not exist yet: a block of functions sharing the same parameters is a type, and a column marked in nearly every row is a constructor argument. It also guards against the opposite failure of over-objectification.

Triggered heuristics are prompts to look, never findings on their own, and a violation with no concrete cost is not reported. It does not cover correctness, security, performance, test quality, or formatting style, which belong to other review passes.