review-performance

Analyze Apache Pinot diffs for hot-path performance regressions with severity tags.

6.1k|1.5k|Updated May 19, 2014
One-click install
npx skills add https://github.com/apache/pinot --skill review-performance-apache
Or copy as Structured Prompt for Agent
Please help me install this Agent Skill.
Skill: review-performance
Source: https://github.com/apache/pinot/tree/main/.claude/skills/review-performance
Command: npx skills add https://github.com/apache/pinot --skill review-performance-apache

SYSTEM DOCUMENTATION & REQUIREMENTS

What problem does it solve?

Review diffs in Apache Pinot to detect performance regressions in hot-path code, helping engineers catch slowdowns before they reach production.

Core Features & Use Cases

  • Broad per-path scanning of hot-path components such as TransformOperator, FilterOperator, ForwardIndexReader, and segment scanners to surface per-row allocations, boxing, and synchronized blocks.
  • Severity-guided findings with concrete recommendations and verification steps.
  • Use Case: during PR reviews, identify regressions in query paths and propose targeted optimizations to restore performance.

Quick Start

Run a code-review pass on the latest PR focusing on hot-path components and produce a structured report with severity labels and recommended mitigations.

Frequently Asked Questions about review-performance

High-intent search queries and answers about installing and using this skill.

FAQPage Schema
How do I detect performance regressions in Apache Pinot query paths during code review?

Performance regression detection in Apache Pinot query paths involves reviewing code diffs to surface per-row allocations, boxing, and synchronized blocks. It targets hot-path components like TransformOperator and FilterOperator to flag slowdowns before they reach production.

What common performance issues should I look for in Pinot segment scan and ForwardIndexReader diffs?

Common performance issues in Pinot segment scan and ForwardIndexReader diffs include per-row memory allocations, primitive boxing, synchronized blocks, and missing fast-paths. These inefficiencies in core per-row operators significantly degrade query throughput and scan latency.

How are performance review findings categorized for Pinot hot-path code changes?

Performance review findings for Pinot hot-path code changes are categorized using severity tags: CRITICAL, MAJOR, and MINOR. This severity-guided approach pairs concrete recommendations and verification steps with each flagged allocation or synchronization regression.

Does this code review process apply to all Apache Pinot components or only specific per-row operators?

This code review process applies specifically to Apache Pinot per-row operator paths and related core areas. It targets TransformOperator, FilterOperator, ForwardIndexReader, and segment scanners to identify hot-path regressions rather than covering all Pinot components generally.

Can I use this hot-path review approach for Pinot PRs that do not modify query execution operators?

This hot-path review approach is not suited for Pinot PRs that do not modify query execution operators. It specifically analyzes diffs in per-row paths like TransformOperator, FilterOperator, and ForwardIndexReader to catch performance regressions in critical segment scan logic.