review-tf

Use gh pr diff to fetch the pull request changes, then inspect the Terraform code for dependency issues, missing depends_on declarations, and hardcoded values. Post findings as inline review comments on the corresponding diff lines.

Check three main aspects: whether locals or variables unnecessarily indirect references that could point directly at resources, whether implicit dependencies need explicit depends_on blocks, and whether hardcoded values should become data resources.

Use depends_on when a resource has an implicit dependency that Terraform cannot infer from attribute references alone. Explicit declaration ensures correct creation and destruction ordering for these hidden relationships.

Replace hardcoded values with data resources when the value references existing external infrastructure, such as AMI IDs, VPC IDs, or account details. Data sources keep configuration synchronized with the actual environment state.

No, the review criteria are specific to Terraform constructs like locals, variables, depends_on, and data resources. Other IaC tools such as CloudFormation or Pulumi would require different review perspectives.