skills.rest
daominah
daominahCOMMUNITY
Explore all skills by this author →
GitHub

reviewing-code-and-pr

Review code changes and pull requests for business fit, quality, and security.

Updated Mar 25, 2020
Search Tags:#code quality#testing#static analysis#code review#pull request#security#observability
One-click install
npx skills add https://github.com/daominah/gostructure --skill reviewing-code-and-pr
Or copy as Structured Prompt for Agent▼
Please help me install this Agent Skill.
Skill: reviewing-code-and-pr
Source: https://github.com/daominah/gostructure/tree/main/.claude/skills/reviewing-code-and-pr
Command: npx skills add https://github.com/daominah/gostructure --skill reviewing-code-and-pr

SYSTEM DOCUMENTATION & REQUIREMENTS

What problem does it solve?

This Skill provides a structured, repeatable checklist and output format to evaluate code changes and pull requests for business fit, implementation correctness, regressions, observability, security, and overall code quality, reducing missed issues during reviews and speeding safe merges.

Core Features & Use Cases

  • Structured Review Output: Produces a clear verdict (APPROVE or REQUEST_CHANGES), a concise summary, and optional Blockers, Suggestions, and Nitpicks for consistent reviewer communication.
  • Review Criteria Guidance: Covers verifying linked tickets or problem statements, tests that prove behavior, regression risk, observability and metrics, security checks, and code quality best practices.
  • Use Case: Use when reviewing local uncommitted changes, comparing the latest commit to the previous one, or evaluating a pull request before merging to ensure the change meets requirements and safety standards.

Quick Start

Review the pull request focusing on business fit, implementation approach, regressions, observability, security, tests, and code quality, then output the Verdict, Summary, and any Blockers, Suggestions, or Nitpicks.

Frequently Asked Questions about reviewing-code-and-pr

High-intent search queries and answers about installing and using this skill.

FAQPage Schema
How do I review a pull request for safe merges and regressions?▼

Reviewing a pull request for safe merges involves verifying linked tickets, tests, static analysis, observability, and security checks to produce a structured verdict of APPROVE or REQUEST_CHANGES with blockers, suggestions, and nitpicks.

What should a code review checklist cover for security and observability?▼

A code review checklist for security and observability should verify security checks, observability metrics, regression risks, tests proving behavior, and code quality best practices to produce a structured verdict.

How do I structure pull request feedback to request changes or approve?▼

Structuring pull request feedback involves outputting a clear verdict (APPROVE or REQUEST_CHANGES), a concise summary, and categorized lists of blockers, suggestions, and nitpicks to ensure consistent reviewer communication.

Can I use this approach to review uncommitted local changes before committing?▼

Yes, this structured review approach applies to uncommitted local changes, latest-commit diffs, and pull requests during pre-merge reviews and QA cycles to assess business fit, implementation quality, and regressions.

What is the best way to verify test coverage and static analysis during code review?▼

The best way to verify test coverage and static analysis during code review is to validate that tests prove behavior, confirm static analysis results, and check linked tickets before producing a structured APPROVE or REQUEST_CHANGES verdict.

Related Skills

Explore More Software Engineering Skills→
ulpi-ioulpi-io
13

claude-review

Spawn a Claude Code agent in an isolated worktree to review code changes.

Official
Advanced
aws-samplesaws-samples
21

pr-review

Fetch GitHub PR diffs, run code-quality checks, and post structured reviews.

Official
Advanced
aronpcaronpc
1

qa

Execute an 11-phase QA workflow for Laravel projects and pull requests.

Community
Advanced
ascerra-fullsend-rehearsalascerra-fullsend-rehearsal

code-review

Analyze code changes for correctness, security, intent, style, and documentation compliance.

Official
Advanced