skills.rest
dotnet
dotnetOFFICIAL
Explore all skills by this author →
Website𝕏@dotnetfdnGitHub

reviewing-compiler-prs

Reviews F# compiler pull requests across 19 dimensions using parallel subagents.

4.3k|872|Updated Jan 10, 2015
Search Tags:#static analysis#compiler#fsharp#binary compatibility#Code review#Multi-Agent#Pull request
One-click install
npx skills add https://github.com/dotnet/fsharp --skill reviewing-compiler-prs
Or copy as Structured Prompt for Agent▼
Please help me install this Agent Skill.
Skill: reviewing-compiler-prs
Source: https://github.com/dotnet/fsharp/tree/main/.github/skills/reviewing-compiler-prs
Command: npx skills add https://github.com/dotnet/fsharp --skill reviewing-compiler-prs

SYSTEM DOCUMENTATION & REQUIREMENTS

What problem does it solve?

Reviewing changes to the F# compiler requires deep expertise across type checking, IL emission, binary compatibility, and IDE performance, and a single-pass review often produces shallow analysis or false positives.

Core Features & Use Cases

  • Dimension-Based Review: Selects relevant review dimensions (type system, IL emission, binary compatibility, parser integrity, IDE responsiveness) based on which files the PR touches.
  • Parallel Subagent Dispatch: Launches an independent subagent per dimension that returns structured findings with file, line, severity, and suggested fix.
  • False-Positive Filtering: Applies assessment gates and cross-model agreement scoring to discard speculative findings and deprioritize nitpicks.
  • Use Case: A maintainer receives a PR modifying src/Compiler/Checking/ and invokes this Skill to get consolidated, deduplicated inline review comments covering type system correctness, overload resolution, and feature gating.

Quick Start

Review this F# compiler pull request and post consolidated findings for each affected dimension.

Frequently Asked Questions about reviewing-compiler-prs

High-intent search queries and answers about installing and using this skill.

FAQPage Schema
How do I review an F# compiler pull request?▼

Invoke the reviewing-compiler-prs skill on the PR. It selects review dimensions based on changed files, dispatches a subagent per dimension, and consolidates structured findings into inline comments ranked by severity and cross-model agreement.

What review dimensions does the F# compiler PR review cover?▼

It covers 19 dimensions including type system correctness, overload resolution, IL emission, binary compatibility, parser integrity, FSharp.Core stability, IDE responsiveness, concurrency, memory footprint, and build infrastructure, selected based on which files changed.

How does the review avoid false positives in compiler PRs?▼

Findings pass assessment gates requiring a concrete failing scenario and correct execution-context understanding. Speculation is downgraded to LOW, improvements are separated from regressions, and cross-model agreement of at least two models raises confidence.

Does the review handle FSharp.Core and binary compatibility changes?▼

Yes. PRs touching FSharp.Core focus on stability, API surface, backward compatibility, and XML docs, while changes to TypedTreePickle or CompilerImports trigger the highest-priority binary compatibility checks.

When should I not use multi-agent compiler PR review?▼

For test-only PRs a quick manual check suffices: verify baselines are explained, cross-TFM coverage exists, and tests actually assert. Full multi-dimension review is intended for changes to compiler, core library, or IDE integration code.

Related Skills

Explore More Software Engineering Skills→
cryptopaficryptopafi

github-code-review

Review git diffs and GitHub pull requests with structured feedback.

Community
Intermediate
paulbrittainpaulbrittain

review-and-ship

Review feature branch diffs for bugs, regressions, and security issues.

Community
Intermediate
swarm-ai-safetyswarm-ai-safety
39

regression-check

Re-run pytest suites and compare performance metrics against historical baselines.

Official
Intermediate
SAZO-KRSAZO-KR

document

Refresh docs.md files after code changes to keep Noridocs accurate.

Official
Intermediate