reviewing-personhog-protocol

Reviews personhog coordination-protocol changesets through adversarial two-pass analysis and layered verification.

713|118|Updated Aug 11, 2020
One-click install
npx skills add https://github.com/PostHog/posthog-foss --skill reviewing-personhog-protocol
Or copy as Structured Prompt for Agent
Please help me install this Agent Skill.
Skill: reviewing-personhog-protocol
Source: https://github.com/PostHog/posthog-foss/tree/main/.agents/skills/reviewing-personhog-protocol
Command: npx skills add https://github.com/PostHog/posthog-foss --skill reviewing-personhog-protocol

SYSTEM DOCUMENTATION & REQUIREMENTS

💡 This Skill includes references (resource) components.

What problem does it solve?

Distributed coordination-protocol defects survive ordinary code review because every component looks correct in isolation — the bugs live in compositions like races across authority transitions, timescale coincidences, and rarely-taken exit paths that skip fencing. This Skill encodes the review process that actually catches them before personhog protocol changes ship.

Core Features & Use Cases

  • Adversarial two-pass review: Runs an author pass against eight lens dimensions (authority transitions, observation latency, timescale interactions, budget semantics, lifecycle, primitive semantics, failure-path parity, escalation legibility), then spawns a cold-context agent for an independent adversarial pass with ranked CONFIRMED/PLAUSIBLE findings.
  • Layered verification gates: Checks each change against stateright model-checking, real-etcd protocol integration tests, e2e harness gate scenarios, mixed-fleet compatibility, and observability/residual-ledger updates.
  • Fix discipline: Enforces red-check-every-fix validation, one regression test per fix, and invariant comments on counter/budget/threshold changes.
  • Use Case: Before pushing a change to personhog lease fencing or handoff logic, run this review to catch a drain bound that exceeds the keepalive renewal margin — a defect that only appears when the constants table is checked pairwise.

Quick Start

Review my personhog coordination-protocol diff for authority-transition races, timescale interactions, and missing regression tests before I request review.

Frequently Asked Questions about reviewing-personhog-protocol

High-intent search queries and answers about installing and using this skill.

FAQPage Schema
How do I review distributed coordination protocol changes for race conditions?

Use a two-pass adversarial review: first sweep the full diff against lens dimensions like authority transitions and observation latency, then spawn a cold-context agent with the protocol invariants but not your conclusions. Verify every finding against code before accepting it, and re-review after each fix batch.

How to test etcd lease fencing and failover behavior?

Route the component's etcd store through a byte-forwarding TCP proxy the test controls — sever live connections to simulate blips, refuse new ones to simulate outages. Pin every behavioral change with an integration test against real etcd that fails on the old code.

What is the red-check discipline for regression tests?

Red-checking means temporarily disabling a fix, running the new test to confirm it fails for the predicted reason, then restoring the fix and confirming green. Scratch-copy the file first — never use git checkout for temporary reverts since it destroys uncommitted work.

Does this review process require model checking?

Yes, when the change touches decision logic, phases, or ack semantics — the personhog-stateright model must still compile and its properties must hold. Execution-level changes like concurrency structure can skip model updates, but that must be stated explicitly.

When should mixed-fleet compatibility be checked during review?

Check it whenever a change modifies etcd record shapes, ack semantics, phase meanings, or changelog framing, since rolling deploys run old and new binaries against shared etcd mid-roll. Changes must be read-compatible in both directions across one release or explicitly gated.