skills.rest
stellar
stellarOFFICIAL
Explore all skills by this author →
WebsiteGitHub

validating-a-change

Validates code changes through reviews, tests, multi-configuration builds, and formatting before pull requests.

3.3k|1.1k|Updated Nov 24, 2014
Search Tags:#Git#C++#code validation#Testing#Sanitizers#Code review#Pull request
One-click install
npx skills add https://github.com/stellar/stellar-core --skill validating-a-change
Or copy as Structured Prompt for Agent▼
Please help me install this Agent Skill.
Skill: validating-a-change
Source: https://github.com/stellar/stellar-core/tree/main/.claude/skills/validating-a-change
Command: npx skills add https://github.com/stellar/stellar-core --skill validating-a-change

SYSTEM DOCUMENTATION & REQUIREMENTS

What problem does it solve?

Before opening a pull request, developers need confidence that a change is correct, tested, and properly formatted. This Skill orchestrates a complete validation pipeline so no verification step is forgotten or skipped.

Core Features & Use Cases

  • Ordered Validation Pipeline: Runs high-level code review, low-level code review, test addition, test execution, multi-configuration builds (ASan, TSan, UBSan, fuzz tests), and formatting in a strict sequence.
  • Subagent Orchestration: Delegates long-running steps to focused subagents that compose other skills like code review, test running, and build configuration.
  • Issue Resolution In-Place: Each step fully fixes its own issues before proceeding, avoiding restarts from the beginning.
  • Use Case: After implementing a bug fix in stellar-core, invoke this Skill to review the diff, add missing tests, run the full test suite across sanitizer builds, and confirm the change is pull-request ready.

Quick Start

Validate my current uncommitted changes for the ledger bug fix and confirm they are ready for a pull request.

Frequently Asked Questions about validating-a-change

High-intent search queries and answers about installing and using this skill.

FAQPage Schema
How do I validate a code change before opening a pull request?▼

Run the validation pipeline which performs high-level and low-level code reviews, adds missing tests, runs the full test suite, builds with multiple configurations, and formats the code. Each step fixes its own issues before moving forward.

What steps are included in the change validation workflow?▼

The workflow includes six ordered steps: high-level code review, low-level code review, adding tests, running tests at levels 1-3, building and testing with sanitizer and fuzz configurations, and running make format.

Does the validation run tests with sanitizers like ASan and TSan?▼

Yes, step five builds and tests with ASan, TSan, and UBSan configurations, plus extra checks and randomized fuzz tests for protocol-critical code. It also verifies the production build with --disable-tests succeeds.

Can validation steps run in parallel to save time?▼

No, subagents must never run in parallel because they may conflict with each other. Each step must fully complete and resolve its issues before the next step begins.

What happens if a validation step keeps failing?▼

If validation gets stuck in a loop, the Skill reports which step keeps failing, what issues recur, and whether the fundamental approach needs reconsideration rather than retrying indefinitely.

Related Skills

Explore More Software Engineering Skills→
herren-officialherren-official

b2b-web-create-commit

Generate type-based Git commits from analyzed code changes.

Official
Advanced
zorgentechzorgentech

merge-request

Resolves GitHub pull requests by orchestrating checks, threads, fixes, merges via gh CLI.

Official
Advanced
awfixers-stuffawfixers-stuff

clang

Recommend Clang flags, clang-tidy checks, and LTO/PGO workflows for C and C++ projects.

Official
Intermediate
spallempatispallempati

pr-review-requirements

Enforce mandatory peer review and automated quality gates on pull requests.

Community
Intermediate