vmcp-review

Reviews vMCP Go code changes for known anti-patterns and classifies findings by severity.

2.1k|283|Updated Mar 12, 2025
One-click install
npx skills add https://github.com/stacklok/toolhive --skill vmcp-review
Or copy as Structured Prompt for Agent
Please help me install this Agent Skill.
Skill: vmcp-review
Source: https://github.com/stacklok/toolhive/tree/main/.claude/skills/vmcp-review
Command: npx skills add https://github.com/stacklok/toolhive --skill vmcp-review

SYSTEM DOCUMENTATION & REQUIREMENTS

What problem does it solve?

Reviewing vMCP code changes manually risks missing recurring anti-patterns that increase cognitive load, create brittle dependencies, and undermine testability across the codebase.

Core Features & Use Cases

  • Scoped Review: Examines only changed files in a PR or diff under pkg/vmcp/ and cmd/vmcp/, or audits all Go files in a target package.
  • Anti-Pattern Detection: Checks code against the anti-patterns defined in .claude/rules/vmcp-anti-patterns.md, applying judgment about which checks are relevant.
  • Severity Classification: Classifies each finding as Must Fix, Should Fix, or Note, and reports clean checks explicitly.
  • Use Case: When reviewing a pull request that modifies the vMCP server aggregation logic, run this Skill to detect newly introduced anti-patterns and produce a structured review report.

Quick Start

Review the vMCP changes in this pull request for known anti-patterns and report findings by severity.

Frequently Asked Questions about vmcp-review

High-intent search queries and answers about installing and using this skill.

FAQPage Schema
How do I review vMCP code changes for anti-patterns?

Run the vmcp-review skill on the changed files under pkg/vmcp/ and cmd/vmcp/. It checks the code against the anti-patterns in .claude/rules/vmcp-anti-patterns.md and reports findings grouped by severity.

What does the vMCP code review check for?

It checks for known anti-patterns that increase cognitive load, create brittle dependencies, or undermine testability. Findings are classified as Must Fix, Should Fix, or Note depending on whether the change introduces or expands the pattern.

Can I audit an entire vMCP package instead of a pull request?

Yes. When auditing a package, the skill examines all Go files in the target package rather than only changed files. It still skips anything outside the vMCP codebase.

Does the vMCP review cover security or general Go style issues?

No. General Go style is handled by golangci-lint, security issues by the security-advisor agent, and test quality by the unit-test-writer agent. This skill focuses only on vMCP-specific anti-patterns.

What are the limitations of the vMCP anti-pattern review?

It only applies to code under pkg/vmcp/ and cmd/vmcp/, and it does not cover performance issues unless they stem from an anti-pattern like repeated body parsing. Non-vMCP code should go to the general code-reviewer agent.