skills.rest
gvinokur
gvinokurCOMMUNITY
Explore all skills by this author →
GitHub

plan-reviewer

Validate implementation plans for design, signature, and test coverage issues.

Updated Nov 8, 2022
Search Tags:#typescript#tdd#architecture#code-review#plan-review#haiku#test-strategy
One-click install
npx skills add https://github.com/gvinokur/qatar-prode --skill plan-reviewer-gvinokur
Or copy as Structured Prompt for Agent▼
Please help me install this Agent Skill.
Skill: plan-reviewer
Source: https://github.com/gvinokur/qatar-prode/tree/main/.claude/skills/plan-reviewer
Command: npx skills add https://github.com/gvinokur/qatar-prode --skill plan-reviewer-gvinokur

SYSTEM DOCUMENTATION & REQUIREMENTS

What problem does it solve?

This Skill reduces PR rework and missed test coverage by validating mid-level design and test strategies before committing a plan to a pull request, catching structural, signature, and testing gaps early.

Core Features & Use Cases

  • Dual-persona review loop: Runs 2–3 Haiku cycles with Persona A (The Architect) validating Mid-Level Design and Persona B (The TDD Engineer) validating test scenarios until no significant concerns remain.
  • Targeted checks: Verifies TypeScript signatures reference project types, enforces a Call Graph Changes subsection, ensures Calls: lists only project functions, and requires ≥3 test cases per exported function.
  • Test hygiene validation: Confirms happy paths, error and edge cases are covered and that tests use project factories and mock helpers rather than inline mocks.
  • Use Case: Use this to validate STORY-123 plan.md after plan creation and before creating the PR to ensure the implementation is testable and architecturally sound.

Quick Start

Run a dual-persona haiku review on the plan file for the target story to surface architectural and test coverage issues before creating a PR.

Frequently Asked Questions about plan-reviewer

High-intent search queries and answers about installing and using this skill.

FAQPage Schema
How do I validate an implementation plan for TypeScript test coverage before creating a PR?▼

Validate an implementation plan by running up to three Haiku review cycles using Architect and TDD personas to check TypeScript signatures, call graph changes, and test coverage. This dual-persona review identifies structural and testing gaps before PR creation.

What is a dual-persona plan review for architecture and TDD compliance?▼

A dual-persona plan review iteratively validates a plan file using an Architect persona for mid-level design and a TDD Engineer persona for test scenarios. It runs multiple Haiku cycles until significant architectural and test coverage concerns are resolved.

How many test scenarios do I need per exported function in a TDD plan review?▼

A TDD plan review requires at least three test scenarios per exported function. These scenarios must cover happy paths, error cases, and edge cases while utilizing project test factories and mock helpers rather than inline mocks.

Does plan review work with repository-level plan files for individual stories?▼

Yes, plan review applies directly to repository-level plan files for individual stories. It validates mid-level design, enforces TypeScript-accurate signatures, and requires a Call Graph Changes section before the plan proceeds to PR creation.

What architectural checks are enforced during a TypeScript plan review?▼

Architectural checks enforce TypeScript-accurate signatures referencing project types, a Call Graph Changes subsection, and Calls: lists containing only project functions. These targeted checks ensure the implementation plan is structurally sound before PR submission.

Related Skills

Explore More Software Engineering Skills→
solace-illsolace-ill

qa-plan

Generate structured QA plans from stories and GDD references.

Community
Advanced
AutisticAFAutisticAF
4

testing-test-data-factory

Generate Swift test data factories with fixed dates and UUID defaults.

Community
Intermediate
hdickohdicko

playwright-generate-test

Translate user scenarios into Playwright TypeScript test files.

Community
Advanced
DenissvgnDenissvgn

critic

Validate deliverables against requirements by examining architecture, test coverage, and implementation artifacts.

Community
Basic