Verify test coverage and quality for Pinot diffs and integration-test readiness.
npx skills add https://github.com/apache/pinot --skill review-testing-apache
Please help me install this Agent Skill. Skill: review-testing Source: https://github.com/apache/pinot/tree/main/.claude/skills/review-testing Command: npx skills add https://github.com/apache/pinot --skill review-testing-apache
This Skill provides a structured approach for code reviewers to verify test coverage and quality in Pinot diffs, ensuring regression coverage, appropriate use of mocks, and integration-test readiness across versions.
Review the PR’s test changes and apply this guide to assess coverage, mocks usage, and integration-test readiness
High-intent search queries and answers about installing and using this skill.
To review test coverage for Pinot diffs, systematically evaluate changes in src/test/**, verify positive and negative cases, and ensure regression tests exist for modified code paths. This structured approach confirms alignment with documented review principles and flags missing tests.
The recommended base class for Pinot integration tests is CustomDataQueryClusterIntegrationTest. Reviewers should flag standalone cluster tests when they are required, ensuring integration-test readiness and proper mixed-version testing patterns across the codebase.
Use real dictionaries instead of mocks when evaluating src/test/** changes to ensure accurate test coverage. Reviewers must verify appropriate mock usage and flag inappropriate test patterns that might hide regressions in null-handling logic or type-dispatch changes.
Classify test severity issues during code review using a framework of CRITICAL, MAJOR, and MINOR levels. This structure helps prioritize missing tests, inappropriate test patterns, and inadequate regression coverage found in Pinot diffs.
Yes, this code review guide applies to PRs modifying new wire-format or integration-test scenarios, type-dispatch changes, and code paths with null-handling logic. It ensures concrete test-signature recommendations reproduce regressions effectively.
apacheAudit Pinot code diffs for null handling, type dispatch, and numeric precision.
multiversxVerify smart contract bug fixes by running Mandos scenarios and regression tests.
HomericIntelligenceDetect code smells and complexity issues in codebases.
tw-kangRun a single CUBRID JDBC test class and report pass or fail.
