review-correctness-nulls

Audit Pinot code diffs for null handling, type dispatch, and numeric precision.

6.1k|1.5k|Updated May 19, 2014
One-click install
npx skills add https://github.com/apache/pinot --skill review-correctness-nulls
Or copy as Structured Prompt for Agent
Please help me install this Agent Skill.
Skill: review-correctness-nulls
Source: https://github.com/apache/pinot/tree/main/.claude/skills/review-correctness-nulls
Command: npx skills add https://github.com/apache/pinot --skill review-correctness-nulls

SYSTEM DOCUMENTATION & REQUIREMENTS

What problem does it solve?

Review Pinot diffs for correctness issues — null handling, type dispatch, numeric precision, exhaustive switch coverage, and safe lifecycle management.

Core Features & Use Cases

  • Identify null-handling bugs and off-by-one errors in diff scenarios.
  • Verify exhaustive switch coverage for DataType / IndexType with proper default behavior.
  • Detect resource leaks in close/destroy paths and ensure safe cleanup.

Quick Start

Review the latest Pinot PR diffs for null-vector paths, exhaustive switch coverage, and resource-cleanup on segment close/destroy.

Frequently Asked Questions about review-correctness-nulls

High-intent search queries and answers about installing and using this skill.

FAQPage Schema
How do I check Pinot code diffs for null-handling bugs and type dispatch issues?

You can audit Pinot diffs for null-handling bugs by reviewing null-vector paths, DataType and IndexType switches for exhaustive coverage, and numeric precision handling to catch off-by-one errors.

What is exhaustive switch coverage for DataType and IndexType in Pinot?

Exhaustive switch coverage for DataType and IndexType in Pinot ensures that all enum cases are explicitly handled in type dispatch logic, preventing unhandled scenarios and enforcing correct default behaviors.

How do I detect resource leaks in Pinot segment close and destroy paths?

To detect resource leaks in Pinot segment close and destroy paths, review the lifecycle code diffs to verify safe cleanup operations are executed and clear error signaling is implemented.

Does this code review process handle numeric precision and off-by-one errors in Pinot?

Yes, the code review process handles numeric precision and off-by-one errors in Pinot by auditing diff scenarios to verify proper precision calculations and safe null-vector path execution.

What are the limitations of automated Pinot diff audits for null-safety and correctness?

The limitations of Pinot diff audits include focusing strictly on correctness issues in null handling, type dispatch, numeric precision, and segment lifecycle, meaning general logic or architectural flaws are not covered.